Fixed an issue where tags wouldn't get cleared when removed from content #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens when using a combination of culture specific and explicit group key.
The issue can be reproduced by creating property using the following configuration:
Adding tags works fine, and also removing tags work fine in the editor view.
However, when using
ITagEngine.GetContentReferencesByTagsthe returned results includes theIContentwhere the tags were removed. Upon further investigation I found that the tags won't get deleted inTagService.RemoveOldContentTags()since the tagGroupKeydoesn't match theIContentslanguagebranch.In the previous case the tag's GroupKey will be
articles:svorarticles:en, butTagService.RemoveOldContentTags()will skip since it looks forsvorenspecifically.Changing
tag.GroupKey != languageto!tag.GroupKey.EndsWith(language)fixes this problem since the language be appended to the groupkey inTagsHelper.GetGroupKeyFromAttributes():