Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isValidSchema & isValidStore functions #5

Merged
merged 1 commit into from Mar 4, 2020

Conversation

@gabbanaesteban
Copy link
Contributor

gabbanaesteban commented Mar 4, 2020

As you now are using affirmative names for Boolens checking functions, you should use AND instead of OR in these checking functions.

@gabbanaesteban gabbanaesteban changed the title Update Mantra.js Fix isValidSchema & isValidStore functions Mar 4, 2020
@gabbanaesteban gabbanaesteban marked this pull request as ready for review Mar 4, 2020
@carlospgraciano carlospgraciano self-requested a review Mar 4, 2020
@carlospgraciano

This comment has been minimized.

Copy link
Collaborator

carlospgraciano commented Mar 4, 2020

Thanks, @gabbanaesteban for pointing that out. If this fix would've not been proposed, we would've got a false positive regarding the validations in Mantra's Vue install process.

@carlospgraciano carlospgraciano merged commit f7d8267 into Gewaer:master Mar 4, 2020
2 checks passed
2 checks passed
DEP All dependencies are resolved
YAMBURGER 0 nothingburger(s)
Details
@gabbanaesteban gabbanaesteban deleted the gabbanaesteban:patch-2 branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.