Skip to content

Commit 48ffa2e

Browse files
committed
Fix: Books showing up on lecterns
1 parent 3006fe3 commit 48ffa2e

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

core/src/main/java/org/geysermc/geyser/level/block/type/LecternBlock.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
import org.cloudburstmc.nbt.NbtMap;
3030
import org.cloudburstmc.nbt.NbtMapBuilder;
3131
import org.cloudburstmc.nbt.NbtType;
32-
import org.geysermc.geyser.level.WorldManager;
3332
import org.geysermc.geyser.level.block.property.Properties;
3433
import org.geysermc.geyser.session.GeyserSession;
3534
import org.geysermc.geyser.translator.level.block.entity.BedrockChunkWantsBlockEntityTag;
@@ -50,13 +49,9 @@ public NbtMap createTag(GeyserSession session, Vector3i position, BlockState blo
5049

5150
@Override
5251
public void updateBlock(GeyserSession session, BlockState state, Vector3i position) {
53-
WorldManager worldManager = session.getGeyser().getWorldManager();
54-
boolean currentHasBook = state.getValue(Properties.HAS_BOOK);
55-
Boolean previousHasBook = worldManager.blockAt(session, position).getValueNullable(Properties.HAS_BOOK); // Can be null if not a lectern, watch out
56-
if (previousHasBook == null || currentHasBook != previousHasBook) {
57-
BlockEntityUtils.updateBlockEntity(session, getBaseLecternTag(position, currentHasBook), position);
58-
}
5952
super.updateBlock(session, state, position);
53+
boolean hasBook = state.getValue(Properties.HAS_BOOK);
54+
BlockEntityUtils.updateBlockEntity(session, getBaseLecternTag(position, hasBook), position);
6055
}
6156

6257
public static NbtMap getBaseLecternTag(Vector3i position, boolean hasBook) {

0 commit comments

Comments
 (0)