Fixed heap corruption, extra byte for NULL termination symbol #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated here in general case we need to allocate
N+1
bytes for string of lengthN
in order to copy overNULL
termination byte, otherwise we'll corrupt heap memory withstrcpy
call.So, in this case we need to allocate
strlen(color_str)
bytes, as we're omitting first symbol.Testcase which I used to test if I'm right about this: