Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reflected XSS vulns in both default themes #48

Merged
merged 1 commit into from Oct 13, 2019

Conversation

@rastating
Copy link
Contributor

rastating commented Oct 12, 2019

In the blog-list.php view of both themes included in Gila (gila-blog and gila-mag), there is a lack of HTML entity encoding, which leads to reflected cross-site scripting being possible in the search results.

An example of this can be in the console of the screenshot below when visiting the URL: /?search=xss%22+onfocus%3D%22console.log%28document.domain%29%22+autofocus%3D%22true

Screenshot from 2019-10-12 21-31-06

This pull request fixes both instances of this by parsing the user input through htmlentities first.

@vzuburlis vzuburlis merged commit 3c8c5be into GilaCMS:master Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.