Skip to content

Update position on scroll (when appendToBody=true) #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2015
Merged

Update position on scroll (when appendToBody=true) #20

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2528f68
Merge pull request #1 from Gillardo/master
AlexFess May 21, 2015
6927fa0
Update position on scroll (when appendToBody=true)
AlexFess May 21, 2015
262f0a9
Update position on scroll w/o jQuery
AlexFess May 21, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 36 additions & 5 deletions datetime-picker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,21 @@
angular.module('ui.bootstrap.datetimepicker', ['ui.bootstrap.dateparser', 'ui.bootstrap.position'])
/**
* Add parents() to jqLite.
*/
if (!angular.element.prototype.parents) {
angular.element.prototype.parents = function() {
var res = [];
for (var i = 0; i < this.length; i++) {
var el = this[i];
while (el.parentNode && el.parentNode.nodeType == 1) {
res.push(el.parentNode);
el = el.parentNode;
}
}
return angular.element(res);
};
}

angular.module('ui.bootstrap.datetimepicker', ['ui.bootstrap.dateparser', 'ui.bootstrap.position'])
.directive('datetimePicker', ['$compile', '$parse', '$document', '$timeout', '$position', 'dateFilter', 'dateParser', 'datepickerPopupConfig',
function ($compile, $parse, $document, $timeout, $position, dateFilter, dateParser, datepickerPopupConfig) {
return {
Expand Down Expand Up @@ -238,18 +255,32 @@
}
};

var reposition = function() {
scope.position = appendToBody ? $position.offset(element) : $position.position(element);
scope.position.top = scope.position.top + element.prop('offsetHeight');
if (appendToBody) {
scope.position.right = $document.width() - scope.position.left - element.parent().width();
}
}

var repositionScrollHandler = function() {
console.log('reposition');
scope.$apply(reposition);
}

scope.$watch('isOpen', function (value) {
if (value) {
scope.$broadcast('datepicker.focus');
scope.position = appendToBody ? $position.offset(element) : $position.position(element);
scope.position.top = scope.position.top + element.prop('offsetHeight');
reposition();
if (appendToBody) {
scope.position.right = $document.width() - scope.position.left - element.parent().width();
element.parents().on('scroll', repositionScrollHandler);
}

$document.bind('mousedown', documentClickBind);
} else {
$document.unbind('mousedown', documentClickBind);
if (appendToBody) {
element.parents().off('scroll', repositionScrollHandler);
}
}
});

Expand Down