Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Documenter 0.20 #1217

Merged
merged 3 commits into from Nov 10, 2018
Merged

Update to Documenter 0.20 #1217

merged 3 commits into from Nov 10, 2018

Conversation

mortenpi
Copy link
Contributor

@mortenpi mortenpi commented Oct 25, 2018

Not sure if this will actually work.

Due to upcoming breaking changes in Documenter. This makes sure that the doc builds do not start failing when 0.20 lands in METADATA. See this thread on Discourse for more information.

Ref: JuliaDocs/Documenter.jl#861

@codecov-io
Copy link

codecov-io commented Oct 25, 2018

Codecov Report

Merging #1217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1217   +/-   ##
=======================================
  Coverage   73.13%   73.13%           
=======================================
  Files          35       35           
  Lines        4042     4042           
=======================================
  Hits         2956     2956           
  Misses       1086     1086

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b69d958...dfe8e1b. Read the comment docs.

@mortenpi
Copy link
Contributor Author

Ok, it didn't work. I might get back to this in a few days.

@mortenpi mortenpi changed the title Cap Documenter to v0.19 WIP: Cap Documenter to v0.19 Oct 25, 2018
@tlnagy
Copy link
Member

tlnagy commented Oct 28, 2018

Thanks for the PR, did you get a chance to look into this more?

@mortenpi mortenpi changed the title WIP: Cap Documenter to v0.19 Update to Documenter 0.20 Nov 6, 2018
Make the necessary changes to make.jl to be able to build and deploy the
docs properly with Documenter 0.20. Also, switch to docs/Project.toml to
handle the doc build dependencies etc.
@mortenpi
Copy link
Contributor Author

mortenpi commented Nov 6, 2018

Apologies for not getting back to this earlier. So, instead of capping Documenter to 0.19, I've simply updated make.jl so that it would work with the latest version. I also switched to using docs/Project.toml to list the docs-only dependencies.

If Travis passes, it should be good to go. It is also using a build stage now, which means that documentation build failures should also fail Travis now by failing the "Documentation" build stage.

.travis.yml Show resolved Hide resolved
@mortenpi
Copy link
Contributor Author

mortenpi commented Nov 6, 2018

I forgot about this before -- this also makes another change. Currently, the docs from master end up under the http://gadflyjl.org/latest/ URL, but with this PR they start deploying to http://gadflyjl.org/dev/. This is the new recommended default but it can be changed.

If you are OK with changing the URL, I can update the links in the README right away. If not, I'll add a keyword to deploydocs to keep it at latest/.

The latest tagged version will still be available from stable/, so no change to that.

@bjarthur
Copy link
Member

bjarthur commented Nov 8, 2018

i'm find with dev/ instead of latest/. make the change to the REAME and i'll merge.

@mortenpi
Copy link
Contributor Author

Done.

@bjarthur bjarthur merged commit 1ba42cd into GiovineItalia:master Nov 10, 2018
@bjarthur
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants