Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve issue #1374: document color spec. #1388

Merged
merged 1 commit into from
Jan 26, 2020

Conversation

ben-schulz
Copy link
Contributor

Fixes #1374

Contributor checklist:

  • I've updated the documentation to reflect these changes
  • I've added an entry to NEWS.md
  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've squash'ed or fixup'ed junk commits with git-rebase
  • I've built the docs and confirmed these changes don't cause new errors

Proposed changes

and

  • add hyperlink to table in Colors.jl,
  • note the Colorsjl library as the point-of-truth.
  • incorporate revision suggested by @Mattriks.

add hyperlink to table in `Colors.jl`,
and note that library as
the point-of-truth.

incorporate revision suggested by @Mattriks.
@codecov-io
Copy link

codecov-io commented Jan 21, 2020

Codecov Report

Merging #1388 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1388   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files          39       39           
  Lines        4207     4207           
=======================================
  Hits         3798     3798           
  Misses        409      409

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aec6dad...2c2072a. Read the comment docs.

@ben-schulz
Copy link
Contributor Author

ben-schulz commented Jan 25, 2020

also addresses GiovineItalia/Compose.jl#380

@bjarthur bjarthur merged commit 32c12cb into GiovineItalia:master Jan 26, 2020
@bjarthur
Copy link
Member

thanks for this!

also, in general it is preferred to make a change to an existing PR by using git rebase and git push --force than to close the PR and open a new one. not that big of a deal, but it's easier to keep track of comments that way.

@ben-schulz
Copy link
Contributor Author

my mistake; i'll follow that procedure next time. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document color specification
3 participants