Skip to content

Conversation

@Mattriks
Copy link
Member

@Mattriks Mattriks commented Apr 18, 2020

  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've built the docs and confirmed these changes don't cause new errors

This PR:

  • fixes an issue identified on discourse:
    Point 2. layer(Function, ..., order=2) doesn't work.

Example:

using RDatasets
iris = dataset("datasets", "iris")

fs = [ x->0.3x+1, x->0.3x+1.1 ]
cs = ["versicolor", "virginica"]
plot(iris,
  layer(x=:SepalLength, y=:SepalWidth, color=:Species),
  layer(fs, 4, 8, color=cs, order=2),
)

layer_order

@codecov-io
Copy link

codecov-io commented Apr 19, 2020

Codecov Report

Merging #1420 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1420   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files          39       39           
  Lines        4288     4288           
=======================================
  Hits         3841     3841           
  Misses        447      447           
Impacted Files Coverage Δ
src/poetry.jl 90.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e51e2a...1376f74. Read the comment docs.

@Mattriks Mattriks merged commit 7eef73c into GiovineItalia:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants