Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase support for color aesthetic #1438

Merged
merged 1 commit into from
May 17, 2020

Conversation

Mattriks
Copy link
Member

@Mattriks Mattriks commented May 15, 2020

  • I've updated the documentation to reflect these changes
  • I've added an entry to NEWS.md
  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've built the docs and confirmed these changes don't cause new errors

This PR:

  • adds extra support for the syntax color=[colorant"color"]
  • fixes Mixing colorants with Scales #1437
  • Gallery plots updated. Now there are only a few plots which require the syntax
    layer(..., Theme(default_color= )) e.g. Geom.line doesn't directly support single length color.

Example

D = [DataFrame(x=rand(20), y=rand(20), v=g) for g in ["Group1", "Group2"]]

plot(Coord.cartesian(fixed=true),
      layer((x,y)->x+y, 0, 1.0, 0, 1.0),
      layer(D[1], x=:x, y=:y, color=[colorant"blue"]),
      layer(D[2], x=:x, y=:y, color=[colorant"green"]))

colorants_with_Scales

@Mattriks Mattriks merged commit 05bf50f into GiovineItalia:master May 17, 2020
@Mattriks Mattriks mentioned this pull request Jun 21, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixing colorants with Scales
1 participant