Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to GitHub CI #1495

Merged
merged 5 commits into from Nov 13, 2020
Merged

Change to GitHub CI #1495

merged 5 commits into from Nov 13, 2020

Conversation

rikhuijzer
Copy link
Contributor

@rikhuijzer rikhuijzer commented Nov 13, 2020

Fixes #1494

Contributor checklist:

Proposed changes

  • Switch from TravisCI to GitHub Actions.

@rikhuijzer
Copy link
Contributor Author

rikhuijzer commented Nov 13, 2020

Documentation works at https://rikhuijzer.github.io/Gadfly2.jl/dev/. It also has a working favicon #1488.

@rikhuijzer rikhuijzer changed the title Work-in-progress: Add GitHub CI Add GitHub CI Nov 13, 2020
@rikhuijzer rikhuijzer changed the title Add GitHub CI Change to GitHub CI Nov 13, 2020
@rikhuijzer
Copy link
Contributor Author

rikhuijzer commented Nov 13, 2020

At this point, this branch seems to obtain the same CI outputs as the Travis configuration on master for the tests and it fixes the build of the documentation, so I removed the "Work-in-progress" part from the title.

@bjarthur
Copy link
Member

LGTM. @Mattriks ?

@codecov-io
Copy link

codecov-io commented Nov 13, 2020

Codecov Report

Merging #1495 (5f9f88c) into master (ebe9626) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1495   +/-   ##
=======================================
  Coverage   88.94%   88.94%           
=======================================
  Files          39       39           
  Lines        4395     4395           
=======================================
  Hits         3909     3909           
  Misses        486      486           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe9626...5f9f88c. Read the comment docs.

@Mattriks Mattriks merged commit 3a6da5a into GiovineItalia:master Nov 13, 2020
@rikhuijzer rikhuijzer mentioned this pull request Nov 14, 2020
@bjarthur
Copy link
Member

@rikhuijzer the docs built successfully after #1505 was merged, but they do not seem to have been deployed. is that perhaps because CI failed for julia 1.0? anyway to change github CI to fix it? thanks.

@rikhuijzer
Copy link
Contributor Author

@bjarthur Hmm, I should have checked the logs earlier. When looking at the GitHub Actions logs for the change to GitHub Workflow merge [1] and the most recent merged PR [2], I see

 ┌ Info: Deployment criteria:
 │ - ✔ ENV["TRAVIS_REPO_SLUG"]="" occurs in repo="github.com/GiovineItalia/Gadfly.jl.git"
 │ - ✘ ENV["TRAVIS_PULL_REQUEST"]="" is "false"
 │ - ✔ ENV["TRAVIS_TAG"]="" is (i) empty or (ii) a valid VersionNumber
 │ - ✘ ENV["TRAVIS_BRANCH"]="" matches devbranch="master" (if tag is empty)
 │ - ✘ ENV["DOCUMENTER_KEY"] exists
 │ - ✔ ENV["TRAVIS_EVENT_TYPE"]="" is not "cron"
 └ Deploying: ✘

So, it seems that DOCUMETER_KEY does not exist. Could you or someone else with the required permissions add this key? See the instructions in [3].

1: https://github.com/GiovineItalia/Gadfly.jl/runs/1397859352?check_suite_focus=true
2: https://github.com/GiovineItalia/Gadfly.jl/runs/1585199677?check_suite_focus=true
3: JuliaDocs/Documenter.jl#1177 (comment)

@bjarthur
Copy link
Member

done. but it still didn't deploy:

┌ Info: Deployment criteria:
│ - ✔ ENV["TRAVIS_REPO_SLUG"]="" occurs in repo="github.com/GiovineItalia/Gadfly.jl.git"
│ - ✘ ENV["TRAVIS_PULL_REQUEST"]="" is "false"
│ - ✔ ENV["TRAVIS_TAG"]="" is (i) empty or (ii) a valid VersionNumber
│ - ✘ ENV["TRAVIS_BRANCH"]="" matches devbranch="master" (if tag is empty)
│ - ✔ ENV["DOCUMENTER_KEY"] exists
│ - ✔ ENV["TRAVIS_EVENT_TYPE"]="" is not "cron"
└ Deploying: ✘```

@rikhuijzer
Copy link
Contributor Author

It seems that Documenter still looks for Travis, which isn't the case for the CI repository I made at https://github.com/rikhuijzer/Gadfly2.jl, there it says:

┌ Info: Deployment criteria for deploying devbranch build from GitHub Actions:
│ - ✔ ENV["GITHUB_REPOSITORY"]="rikhuijzer/Gadfly2.jl" occurs in repo="github.com/rikhuijzer/Gadfly2.jl.git"
│ - ✔ ENV["GITHUB_EVENT_NAME"]="push" is "push"
│ - ✔ ENV["GITHUB_REF"] matches devbranch="master"
│ - ✔ ENV["GITHUB_ACTOR"] exists
│ - ✔ ENV["DOCUMENTER_KEY"] exists
└ Deploying: ✔

Lets hope that a newer Documenter version solves it, and if not, go from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions CI
4 participants