Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axis labels don't display properly #5

Closed
bananaturtlesandwich opened this issue Jul 7, 2023 · 5 comments
Closed

axis labels don't display properly #5

bananaturtlesandwich opened this issue Jul 7, 2023 · 5 comments

Comments

@bananaturtlesandwich
Copy link
Contributor

Hello! Thank you for the crate, it came around at a great time and is wonderful to work with
Unfortunately though I did find an issue with axis labels in that the y-axis label is not rotated and the x isn't there (?)
I'll try to have a look myself but I'll put this here if I don't know

@bananaturtlesandwich
Copy link
Contributor Author

bananaturtlesandwich commented Jul 7, 2023

okay I looked at the draw_text implementation and it currently doesn't use rotation and anchor - just fixed anchor over here https://github.com/bananaturtlesandwich/egui-plotter so x axis text is working now but rotation still needs some time since instead have to use TextShape

@bananaturtlesandwich
Copy link
Contributor Author

Ok looks like rotation plays weirdly with anchor so I'll look at that tomoz

@Gip-Gip
Copy link
Owner

Gip-Gip commented Jul 17, 2023

Will look at it later today, sorry been busy with other life things. Thanks for contributing!

@bananaturtlesandwich
Copy link
Contributor Author

I have a pr open that fixes it btw if you want to look at that

@Gip-Gip
Copy link
Owner

Gip-Gip commented Jul 23, 2023

I have a pr open that fixes it btw if you want to look at that

looking at it now, thanks again!

Gip-Gip added a commit that referenced this issue Jul 23, 2023
@Gip-Gip Gip-Gip closed this as completed Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants