Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSK 2658] Custom scanner #1763

Merged
merged 18 commits into from
Jan 26, 2024
Merged

[GSK 2658] Custom scanner #1763

merged 18 commits into from
Jan 26, 2024

Conversation

bmalezieux
Copy link
Contributor

@bmalezieux bmalezieux commented Jan 23, 2024

Description

Add an example manager to deal with new data types in the scan report. The example manager should be able to add examples and render html code to be integrated into the report.

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

Copy link

linear bot commented Jan 23, 2024

GSK-2658 Custom Scanner

@Hartorn Hartorn self-requested a review January 23, 2024 14:30
@rabah-khalek rabah-khalek marked this pull request as draft January 23, 2024 15:35
@rabah-khalek
Copy link
Contributor

Could you please also add on this branch a way to disable the "warning" and "Debug your issues in the Giskard hub" parts from the HTML templates?

giskard/scanner/issues.py Outdated Show resolved Hide resolved
giskard/scanner/issues.py Outdated Show resolved Hide resolved
giskard/scanner/issues.py Outdated Show resolved Hide resolved
giskard/scanner/issues.py Outdated Show resolved Hide resolved
giskard/scanner/issues.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rabah-khalek rabah-khalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few typing comments remaining, otherwise it's good.

you pushed by mistake memory_fixtures.csv and memory_tests.csv, could you please remove these?

@rabah-khalek rabah-khalek marked this pull request as ready for review January 24, 2024 15:36
@@ -25,6 +26,42 @@ class IssueGroup:
description: str


class ScanExamples(ABC):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using naming with s for plural elsewhere ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used to manage several examples at once, so I guess the plural is better

giskard/scanner/issues.py Outdated Show resolved Hide resolved
giskard/scanner/issues.py Outdated Show resolved Hide resolved
giskard/scanner/issues.py Outdated Show resolved Hide resolved
giskard/scanner/issues.py Show resolved Hide resolved
giskard/scanner/issues.py Show resolved Hide resolved
giskard/scanner/issues.py Show resolved Hide resolved
giskard/scanner/issues.py Show resolved Hide resolved
giskard/scanner/issues.py Outdated Show resolved Hide resolved
giskard/scanner/issues.py Outdated Show resolved Hide resolved
Copy link
Member

@Hartorn Hartorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miss click

@rabah-khalek rabah-khalek enabled auto-merge (squash) January 26, 2024 08:15
Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
87.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rabah-khalek rabah-khalek merged commit 20f36e6 into main Jan 26, 2024
15 of 16 checks passed
@rabah-khalek rabah-khalek deleted the GSK-2658-custom-scanner branch January 26, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants