GSK-2822 Don't edit global logger level #1806
Conversation
|
|
||
|
|
||
| def test_root_log_level_default_warning(): | ||
| assert logging.root.level == logging.WARNING, 'Root package log level should be set to default "WARNING"' |
There was a problem hiding this comment.
I'm all for this modification, but for scan and worker, we should have some logs, no ?
There was a problem hiding this comment.
Yes you're right, it should be an arg for the CLI to allow flexibility
| ) | ||
|
|
||
| logging.root.setLevel(logging.getLevelName(log_level)) |
There was a problem hiding this comment.
Setting log level does not work for me : if I set it to error, I still have logs from giskard weirdly. Not sure why
There was a problem hiding this comment.
Normally setting Error level to root level should suppress every log even from giskard, in my case worker is still starting with logs.
There was a problem hiding this comment.
Nvm, it was only at start, seems ok after
|
Description
Updated logger to only update giskard log level to INFO by default
Related Issue
Type of Change