Skip to content

Commit

Permalink
FIX (delete snippet): navigate to dashboard after deletion
Browse files Browse the repository at this point in the history
  • Loading branch information
sanusart committed Aug 30, 2018
1 parent 7dd29da commit fcd47e0
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/actions/snippets.js
Expand Up @@ -89,12 +89,12 @@ export const createSnippet = ({
}
});

export const deleteSnippet = (id) => ({
export const deleteSnippet = (id, history) => ({
meta: {
id
},
type: AT.DELETE_SNIPPET,
payload: { id }
payload: { id, history }
});

export const editSnippet = (id) => ({
Expand Down
8 changes: 5 additions & 3 deletions src/components/layout/headers/SnippetHeader.js
Expand Up @@ -5,6 +5,7 @@ import {
get, map, size, toString, isEmpty, join, drop
} from 'lodash/fp';
import styled from 'styled-components';
import { withRouter } from 'react-router-dom';

import {
baseAppColor, colorDanger, colorSuccess, textColor
Expand Down Expand Up @@ -113,7 +114,7 @@ export class SnippetHeader extends React.Component {

toggleStar = (id, starred) => starred ? this.props.unsetStar(id) : this.props.setStar(id);

deleteSnippet = (id) => this.props.deleteSnippet(id);
deleteSnippet = (id) => this.props.deleteSnippet(id, this.props.history);

prepareAndUpdateSnippet = () => {
const snippet = get(this.props.match.params.id, this.props.snippets);
Expand Down Expand Up @@ -377,7 +378,8 @@ SnippetHeader.propTypes = {
toggleSnippetComments: PropTypes.func,
edit: PropTypes.bool,
tempSnippet: PropTypes.object,
comments: PropTypes.object
comments: PropTypes.object,
history: PropTypes.object
};

export default connect(mapStateToProps, {
Expand All @@ -392,4 +394,4 @@ export default connect(mapStateToProps, {
addTempFile: snippetActions.addTempFile,
updateSnippet: snippetActions.updateSnippet,
toggleSnippetComments: snippetActions.toggleSnippetComments
})(SnippetHeader);
})(withRouter(SnippetHeader));
2 changes: 2 additions & 0 deletions src/middlewares/gitHubAPI.js
Expand Up @@ -264,6 +264,8 @@ const gitHubAPIMiddleware = ({ dispatch }) => {
type: AT.DELETE_SNIPPET.SUCCESS,
meta: action.meta
});

action.payload.history.push('/');
}
});
}
Expand Down

0 comments on commit fcd47e0

Please sign in to comment.