Skip to content

Conversation

@salome-voltz
Copy link
Contributor

@salome-voltz salome-voltz commented Oct 28, 2024

What has been done

This MR contains two commits:

  • [feat(config_list): Add JSON output] : Adds JSON output to command ggshield config list
  • [fix(api-status): Update JSON output] : Updates JSON output for command ggshield api-status to include the instance which is checked. (This info is present in the text output).

Also, some stages name for pre-commit have been changed.

PR check list

  • As much as possible, the changes include tests (unit and/or functional)
  • If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry (see doc/dev/getting-started.md). If the changes do not affect the end user, then the skip-changelog label has been added to the PR.

@codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.92%. Comparing base (77fa6a9) to head (def57dd).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
ggshield/cmd/status.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #994   +/-   ##
=======================================
  Coverage   91.91%   91.92%           
=======================================
  Files         181      181           
  Lines        7593     7625   +32     
=======================================
+ Hits         6979     7009   +30     
- Misses        614      616    +2     
Flag Coverage Δ
unittests 91.92% <98.27%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salome-voltz salome-voltz force-pushed the salomevoltz/refacto-json-output branch from 147be06 to 99640d5 Compare October 29, 2024 10:06
@salome-voltz salome-voltz force-pushed the salomevoltz/refacto-json-output branch from b96d0b7 to def57dd Compare October 30, 2024 08:39
Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@agateau-gg agateau-gg merged commit f7779cb into main Oct 30, 2024
33 checks passed
@agateau-gg agateau-gg deleted the salomevoltz/refacto-json-output branch October 30, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants