Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Pull request review threads GQL broken #337
Lol ya, its totally broken. Updated w/ a reply:
Hoping we can get some clarification on what is going on here. Its impossible to get PR review threaded comments atm w/ the GQL API. Huge disappointment.
Okay so I don't think they're going to fix it... so I've found an alternative. @rnystrom
The above endpoint returns an array of comments, in chronological order. It appears to only include comments from a review (it doesn't include the root comment, or other comments in the feed from my testing). The nodes can contain a "in_reply_to_id" which is always the first comment in a "discussion".
So in the above PR I left a comment "Not sure if whatever rule is causing this..." the ID of which is
The same endpoint also has "pull_request_review_id" which can be linked back to the response we already have from the GQL response (By either decoding the
Yeah PRs with a lot of review comments will need paging, haven't the foggiest how we would achieve that though (the endpoint is pageable, but wouldn't know when to trigger additional requests)
There's no way that I can see to find out how many comments a review has either, so no way to detect that
I think yeah leave paging for now, get the first 25 or what ever default response is
@rnystrom I'm removing this from the 1.12 milestone as we have got the functionality in now to see review threads.
I'd opt to leave this issue open though so we can further track the original bug with the GQL API and in hopes that they will, eventually, maybe, probably not, fix it!