add GithubAccess btn to noNewNotifications cell #2085
Conversation
| guard let url = URL(string: "https://github.com/settings/connections/applications/\(Secrets.GitHub.clientId)") | ||
| else { fatalError("Should always create GitHub issue URL") } | ||
| // iOS 11 login uses SFAuthenticationSession which shares credentials with Safari.app | ||
| UIApplication.shared.open(url, options: [:]) |
There was a problem hiding this comment.
Nit: you can omit the options parameter as it defaults to an empty Dictionary.
| make.top.equalTo(emojiLabel.snp.bottom).offset(Styles.Sizes.tableSectionSpacing) | ||
| } | ||
|
|
||
| reviewGithubAccessButton.setTitle("Review GitHub Access...", for: .normal) |
There was a problem hiding this comment.
Should at least be a localized string.
There was a problem hiding this comment.
Yes! Needs this then g2g I think
|
updated! 👍 |
|
If this looks tacky, we could replace with a question mark icon that triggers an alert or ContextMenu that shows Review GitHub Access + help options? We could also put this in the left hand nav bar button's alert controller under "View all", or possibly give it it's own space on the navigation bar. |
|
If this is a button I feel like blue makes more sense and fits better stylistically with the app (Like load more). Gray has a disabled or side note feel, blue gives off a button feel. IMO |
|
@BrianLitwin mind resolving conflicts really quick? |
4 participants
Final:
Thanks for feedback!
quick edit: capitalized the A in "Review GitHub access" in 2nd commit