New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clearer accessibility labels and traits #32

Merged
merged 2 commits into from Jun 29, 2017

Conversation

Projects
None yet
2 participants
@BasThomas
Collaborator

BasThomas commented Jun 29, 2017

What these changes do:

  • Make the "more options" button in an issue / PR be called "More options" instead of "bullet"
  • Make the "add reaction" button in a comment be called "Add reaction" instead of "plus"
  • Add a button trait to both SettingsUserCell and ButtonCell to indicate these are buttons
  • Make the user cell in settings make clear this is an account, and tell us when it is selected (or not)
  • Make the SettingsVC dismissible with a two-finger Z-swipe in VoiceOver mode.
  • Make the "settings" button be called "Settings" instead of "bullets hollow"
  • Remove the button trait from buttons used as labels (eg. the "merged" / "open" / "closed" images)

(ref #118 )

@rnystrom

This comment has been minimized.

Show comment
Hide comment
@rnystrom

rnystrom Jun 29, 2017

Member

omfg, amazing

Member

rnystrom commented Jun 29, 2017

omfg, amazing

@rnystrom rnystrom merged commit ee89f61 into GitHawkApp:master Jun 29, 2017

@BasThomas BasThomas deleted the BasThomas:improve-accessibility branch Jun 30, 2017

@BasThomas BasThomas referenced this pull request Jul 12, 2017

Open

Improve accessibility #118

16 of 29 tasks complete

rnystrom added a commit that referenced this pull request Jul 19, 2017

Merge pull request #32 from BasThomas/improve-accessibility
Add clearer accessibility labels and traits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment