Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist notes - last item deletion is being ignored #148

Closed
danfelipe opened this issue May 25, 2020 · 2 comments
Closed

Checklist notes - last item deletion is being ignored #148

danfelipe opened this issue May 25, 2020 · 2 comments

Comments

@danfelipe
Copy link

danfelipe commented May 25, 2020

This is a bug I found recently. Please let me know if you need more info about this.

Description:
When deleting all the items from a checklist note, these change are being ignored. If there are more items, the delete process works as expected.

I'm not attaching logs since there is nothing to see there about this scenario.

Installed app version: 1.53.0

Steps to reproduce:

Step 1: Create a note with multiple items.
Step1

Step 2: Delete all items and save changes.
Step2

Step 3: Note is reverted to the last state, nothing to commit.
Step3

Expected:
Delete changes are detected similar to deleting when there are other entries on the checklist.

Workaround:
So far the workaround for me has been changing the view of the note to raw and manually deleting the content.
Step4

This way changes are detected and I can commit a note without items as expected.
Step5

@vHanda vHanda closed this as completed in bcbf541 May 26, 2020
@vHanda
Copy link
Contributor

vHanda commented May 26, 2020

Hey Dan.

Thank you for the extremely detailed bug report. It was very easy to reproduce. I'll make a new release (1.54) with the changes in a day or so.

@danfelipe
Copy link
Author

danfelipe commented May 26, 2020

Glad to help. Thanks for your quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants