Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get note modified/created metadata from Git #78

Closed
vHanda opened this issue Mar 4, 2020 · 8 comments
Closed

Get note modified/created metadata from Git #78

vHanda opened this issue Mar 4, 2020 · 8 comments

Comments

@vHanda
Copy link
Contributor

vHanda commented Mar 4, 2020

Currently the modified/created timestamp is fetched from the YAML metadata. However, it isn't always present and many users prefer to not store a YAML header.

GitJournal should fallback to extract this metadata from the git data.

This is going to require deeper integration with git, so I probably won't get to it until the dart_git has the required functionality. Going through libgit2 and the many layers of indirection is too frustrating


Please vote on this issue with a 👍reaction. It's one of the primary mechanisms used to prioritize issues.

@vHanda vHanda changed the title Get note modified/created from Git Get note modified/created metadata from Git Mar 4, 2020
@jrollins
Copy link

jrollins commented Mar 5, 2020

I think this would be a nice simplification, which would allow removing the need for the yaml header. The first line of the note could double as the title in this case. This is in fact how xotes originally worked.

@vHanda
Copy link
Contributor Author

vHanda commented Mar 6, 2020

Definitely. However, I'm still learning towards having the YAML header by default as it allows us to store extra metadata such as Note type and tags.

@vHanda
Copy link
Contributor Author

vHanda commented Aug 19, 2020

This task is currently blocked by packfile format support in dart-git. The moment I implement that, I can then more deeply integrate with Git.

Currently all git operations happen via Flutter -> Android -> NDK -> Custom-c-lib -> libgit2 or Flutter -> ios -> Custom-c-lib -> libgit2. This makes using libgit2 very cumbersome. Hence why I'm slowly working on dart-git.

@jasonwilliams
Copy link

jasonwilliams commented Dec 7, 2020

@vHanda are you tracking packfile format support support in dart-git? I couldn’t see where upstream this was happening.

If his doesn’t happen would it make sense to do this in flutter for now?

@vHanda
Copy link
Contributor Author

vHanda commented Dec 7, 2020

@vHanda are you tracking packfile format support support in dart-git? I couldn’t see where upstream this was happening.

If his doesn’t happen would it make sense to do this in flutter for now?

It's done in dart-git and been tested quite a bit. It "just" needs to be incorporated in GitJournal.

My hands are somewhat injured so I now have to take many breaks in between coding (when I feel up to it), hence the slow progress last month and this one.

I'll write a November recap tomorrow and maybe elaborate (I'm not sure how much detail I want to reveal about my health)

@nbuergi
Copy link

nbuergi commented Feb 17, 2021

Any progress on this? If not, as a potentially easier to implement alternative (or maybe just as workaround until a better solution exists): Why not just use the modified date of the note file in the local system storage? This date also reflects last modified and is presumably very easy to access, I would assume.

Btw thanks for a great and super helpful app!

@vHanda
Copy link
Contributor Author

vHanda commented Feb 23, 2021

Any progress on this? If not, as a potentially easier to implement alternative (or maybe just as workaround until a better solution exists): Why not just use the modified date of the note file in the local system storage? This date also reflects last modified and is presumably very easy to access, I would assume.

Btw thanks for a great and super helpful app!

Sadly, not yet. The workaround you suggested is implemented, but it's flakey.

My rough priority list is -

  • Improve App Marketing Material (icon, app store images, etc)
  • Autocompletion for tags / wiki links (It's the most voted feature)
  • This

@bs
Copy link

bs commented Feb 24, 2021

Really looking forward to this as well! Currently, sorting isn’t working as some have frontmatter (dendron) and some don’t.

Thanks for your work!

@vHanda vHanda added this to the March 2021 milestone Mar 5, 2021
@vHanda vHanda removed this from the 2021-Q2 milestone Oct 21, 2021
@vHanda vHanda closed this as completed in e1ea7a4 Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants