Fix a placeholder for search in Japanese #1769
Open
Conversation
Add shapes for these states
* Add tests for summaryFromDocument * Add tests for summaryToDocument * Add tests for untitled parts (HR)
* Test and fix conversion of empty parts * Cover case of last part empty
This comment has been minimized.
This comment has been minimized.
|
Oh, for realz? So great!!!! |
This comment has been minimized.
This comment has been minimized.
|
It's not ready yet to be used for generating websites or PDFs. We published a release to integrate it into the latest beta of the editor. But we are going to move faster on GitBook v4 in the coming weeks. |
This comment has been minimized.
This comment has been minimized.
|
Looking forward to it! |
* Ignore empty articles, and be more flexible in parsing articles * gitbook: Update markup-it^3.4.0
* Add test for editArticleTitle * Always export articles to links
Auto commit by GitBook Editor
morizyun
changed the title
This was referenced Mar 7, 2020
azu
added a commit
to honkit/honkit
that referenced
this pull request
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I modified a placeholder for search more natural in Japanese.
検索すると入力=>検索ワードを入力Thank you for your cooperation, in advance.