Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a placeholder for search in Japanese #1769

Open
wants to merge 225 commits into
base: master
from

Conversation

@morizyun
Copy link

@morizyun morizyun commented Apr 2, 2017

I modified a placeholder for search more natural in Japanese.

検索すると入力 => 検索ワードを入力

Thank you for your cooperation, in advance.

Soreine and others added 8 commits Jan 12, 2017
* Add tests for summaryFromDocument

* Add tests for summaryToDocument

* Add tests for untitled parts (HR)
* Test and fix conversion of empty parts

* Cover case of last part empty
@nagim

This comment has been minimized.

Copy link

@nagim nagim commented on 856b222 Jan 13, 2017

Oh, for realz? So great!!!! 🙌 🎉 👏

This comment has been minimized.

Copy link
Member Author

@SamyPesse SamyPesse replied Jan 13, 2017

It's not ready yet to be used for generating websites or PDFs. We published a release to integrate it into the latest beta of the editor.

But we are going to move faster on GitBook v4 in the coming weeks.

This comment has been minimized.

Copy link

@nagim nagim replied Jan 14, 2017

Looking forward to it!

SamyPesse and others added 15 commits Jan 24, 2017
* Ignore empty articles, and be more flexible in parsing articles

* gitbook: Update markup-it^3.4.0
* Add test for editArticleTitle

* Always export articles to links
Nicolas Gaborit
Auto commit by GitBook Editor
Soreine
@morizyun morizyun changed the title Fix a placeholder for search in Japanses Fix a placeholder for search in Japanese Apr 2, 2017
@AaronO AaronO force-pushed the GitbookIO:master branch from 2b81e94 to b48f847 Aug 3, 2017
azu added a commit to honkit/honkit that referenced this pull request Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet