New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing for custom chapter-mark and page-break in PDF. #813

Merged
merged 1 commit into from Jul 1, 2015

Conversation

Projects
None yet
2 participants
@MrMaksimize
Contributor

MrMaksimize commented Jun 30, 2015

I'm building a gitbook that needs to compile pretty cleanly to PDF, and the trouble I've been having is with line breaks, and chapter marks.

I would love to be able able to specify these options in book.json, but because they're hard coded in the generator, I am unable to.

So I thought I'd make this PR to get the convo started. The natural progression of this though is be able to take a lot of the ebook-convert PDF options and be able to specify them in book.json. But I didn't want to go down that route yet before discussing it with the project leads.

@SamyPesse

This comment has been minimized.

Show comment
Hide comment
@SamyPesse
Member

SamyPesse commented Jun 30, 2015

@MrMaksimize

This comment has been minimized.

Show comment
Hide comment
@MrMaksimize

MrMaksimize Jul 1, 2015

Contributor

Amended the commit :) Thanks for the heads up!

Contributor

MrMaksimize commented Jul 1, 2015

Amended the commit :) Thanks for the heads up!

SamyPesse added a commit that referenced this pull request Jul 1, 2015

Merge pull request #813 from MrMaksimize/pdf-options
Allowing for custom chapter-mark and page-break in PDF.

@SamyPesse SamyPesse merged commit 4aa8e66 into GitbookIO:master Jul 1, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SamyPesse

This comment has been minimized.

Show comment
Hide comment
@SamyPesse

SamyPesse Jul 1, 2015

Member

Thanks 👍 🍻

Member

SamyPesse commented Jul 1, 2015

Thanks 👍 🍻

@MrMaksimize

This comment has been minimized.

Show comment
Hide comment
@MrMaksimize

MrMaksimize Jul 1, 2015

Contributor

Tys! 🍻

Contributor

MrMaksimize commented Jul 1, 2015

Tys! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment