New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Search Option #3
Comments
Hello, Do you want to search in real-time? Or, |
Hi @prithvianilk! I'm not particular about either of the two methods, they both seem great! I'd prefer whichever can be easily implemented from the two (I feel updating real time might be harder said than done). On the other hand, maybe just displaying a scrollable list of results from a given search query might be the best of both worlds. What do you think would be better? |
Yup, I agree that the scrollable list of results idea is easier to implement than the real-time update and gives an option to scroll through the list ( so "ET", would yield a list of "ETH" and "ETC"), but it has one problem. Since Crypto tickers/symbols are usually only ~4 characters, the list itself would be pretty small. If someone searches for a ticker and searches correctly, it does not make sense to show a list of one element, similarly, if they misspell, they might get an empty list. So a simple search and validation + redirect ( or error message due to invalid ticker ) would be better than a list. Let me know what you think about it! |
That's a fair point, but the search should match both the symbol and the name of the coin too. So if someone searches for "car", ADA should pop up in the list, because it's name is "Cardano". Additionally, I don't think it's a good idea to directly jump into the coin page for a matching coin post search (I'm biased towards showing a results list, even if it's a short one). Edit: Error message when the list is empty does sound like a good idea to me though! |
The name + ticker search sounds good. |
Sounds perfect! Feel free to open a draft PR if you'd want to! |
Description
Add functionality to be able to search for coins, either by name or symbol.
Proposed Solution
Add preferably a search window or shortcut to search for coins. Search can be done either naively, or through a regex maybe? (Unsure of how to search).
The text was updated successfully, but these errors were encountered: