Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIV liquidity dune dashboard #2420

Closed
laurenluz opened this issue Mar 28, 2023 · 64 comments
Closed

GIV liquidity dune dashboard #2420

laurenluz opened this issue Mar 28, 2023 · 64 comments
Assignees
Labels
In Progress P2 A normal to do item or feature.

Comments

@laurenluz
Copy link
Member

We have this awesome GIVeconomy dashboard that was made by Fabio, but it is very out of date: https://dune.com/metacrypto/giveconomy

It would be great to fork this dashboard & add to it so that we can show GIV liquidity on multiple chains, and show what is owned by the DAO, and what is provided by individuals.

Would be great to show:

  • all of our liquidity pools & market depth
  • show all our pools that exist in honeyswap (because they aren't on coingecko)
  • show the % of DAO-owned liquidity vs the % of liquidity provided by individuals

This would be valueable to show to people who are interested in GIV & its stability. (like investors)

@RamRamez

It would be nice to build in dune because it uses on chain data, and then has network effects - it can easily be forked and used by others.

@laurenluz
Copy link
Member Author

@alireza-sharifpour - can you take this? @RamRamez is working on the other GIVpower one in #2419

@alireza-sharifpour
Copy link
Member

@alireza-sharifpour - can you take this? @RamRamez is working on the other GIVpower one in #2419

Yes, I'll work on it. @laurenluz

@clara-zi
Copy link

clara-zi commented Apr 25, 2023

I've migrated the Honeyswap query data to new Dune v2:
https://dune.com/queries/2412287/3959298
https://dune.com/queries/2412298/3959323?d=11
Now shows current data.
(Couldn't show current data on a dashboard, reverted to previous version of query data, so trying to find out why).

@laurenluz
Copy link
Member Author

@aminlatifi I hear you are starting to work on this! This issue is a year old at this point, so although the things mentioned are still good, I have some more context/desires for you...

The purpose of this dashboard is to give an at-a-glance picture of what is going on with the GIVeconomy. Where do we have liquidity, where is the GIV held, who is holding it?

I spoke w/ Griff about it and some points we'd want are:

I think you can get started with this, and then ask questions as you go along. If you need help searching for link to our liquidity pools or other "Where is the GIV" things, I can help w/ that and we can also discuss in the GIVeconomy calls.

You may even know some things I missed :)

@aminlatifi
Copy link
Member

The Dune query engine has changed, and we must create optimized queries to manage our free credit for a month. I could create queries to run in a short time and place them here https://dune.com/aminlatifi/giveconomy
I will put the rest of the diagrams there as well.
@laurenluz Can you make the requirements more specific? it would be ideal if you spec out all diagrams/counters and their definition. The description above is somehow broad. Compiling them and defining the dashboard layout and components one by one will be super helpful and help me progress faster.

@laurenluz
Copy link
Member Author

Hey @aminlatifi I love the dashboard so far. Some feedback:

  1. let's hide the mainnet staking one... since we aren't really supporting that... so those GIV tokens are like... people forgot about them :-D

  2. Is there any real difference between the staked & givpower staking charts? because I think they are sort of redundant. We can remove the "staked" ones entirely because that important staking data is covered in the GIVpower staking charts

  3. Where did you get the mainnet circulating supply number from?
    We should expand circulating supplies to show:

  • total circulating supply (from the API): https://circulating.giveth.io/token-supply
  • GIV circulating on mainnet
  • GIV circulating on gnosis (from omni bridge - excluded addresses
  • GIV circulating on OP mainnet (from optimism bridge - excluded addresses)
  • GIV circulating on polygon zkevm (from polygon zkevm bridge - excluded addresses) --> this is probably 0 right now
  • GIV circulaing on solana (from wormhole bridge - excluded addresses)

When I say "excluded addresses" I basically mean the multisigs etc that Giveth owns that are not really "circulating GIV" (like the GIVgarden multisig)... this repo should have the info that is fed to that coingecko API: https://github.com/Giveth/giv-supply-function/

If you have any questions about those excluded addresses, @divine-comedian is the master here.

  1. small typo on active locked positions "gnosos" should be "gnosis"
    image

  2. For the GIVpower lock charts in general

  • I think they are interesting but I think we really want to show the actual unlock schedule... we want to see when a certain amount of GIVpower will be unlocked.... how much will be unlocked on each round end date, for example. Maybe we can represent this somehow?
  • We also want to show the total amount locked vs. amount staked... somehow... even just showing a % number... GIV locked (for any number of round) / GIV staked total.

@divine-comedian
Copy link
Contributor

The excluded addresses applied to our circulating supply endpoint are found here and are clearly labelled
https://github.com/Giveth/giv-supply-function/blob/main/coingecko/index.js

@laurenluz laurenluz added the P2 A normal to do item or feature. label Apr 18, 2024
@aminlatifi
Copy link
Member

Hey @aminlatifi I love the dashboard so far. Some feedback:

  1. let's hide the mainnet staking one... since we aren't really supporting that... so those GIV tokens are like... people forgot about them :-D
  2. Is there any real difference between the staked & givpower staking charts? because I think they are sort of redundant. We can remove the "staked" ones entirely because that important staking data is covered in the GIVpower staking charts
  3. Where did you get the mainnet circulating supply number from?
    We should expand circulating supplies to show:
  • total circulating supply (from the API): https://circulating.giveth.io/token-supply
  • GIV circulating on mainnet
  • GIV circulating on gnosis (from omni bridge - excluded addresses
  • GIV circulating on OP mainnet (from optimism bridge - excluded addresses)
  • GIV circulating on polygon zkevm (from polygon zkevm bridge - excluded addresses) --> this is probably 0 right now
  • GIV circulaing on solana (from wormhole bridge - excluded addresses)

When I say "excluded addresses" I basically mean the multisigs etc that Giveth owns that are not really "circulating GIV" (like the GIVgarden multisig)... this repo should have the info that is fed to that coingecko API: https://github.com/Giveth/giv-supply-function/

If you have any questions about those excluded addresses, @divine-comedian is the master here.

  1. small typo on active locked positions "gnosos" should be "gnosis"
    image
  2. For the GIVpower lock charts in general
  • I think they are interesting but I think we really want to show the actual unlock schedule... we want to see when a certain amount of GIVpower will be unlocked.... how much will be unlocked on each round end date, for example. Maybe we can represent this somehow?
  • We also want to show the total amount locked vs. amount staked... somehow... even just showing a % number... GIV locked (for any number of round) / GIV staked total.
  1. Ok
  2. We have had like (e.g. honeyswap, ...) that still have giv staked there. They are there probably for trading purpose and are around 800k. So, @laurenluz do you still we must remove them?
  3. I had excluded omni-bridge (gnosis bridge), token distro and LM Gnosis Safe. @divine-comedian Your list includes OneGIV that I added to dune dashboard. But your list misses the LM Gnosis Safe.
    @laurenluz WIll do that, are you sure it's correct? https://circulating.giveth.io/token-supply
  4. Fixed
  5. Will work on it.

@divine-comedian
Copy link
Contributor

@aminlatifi Can you clarify which safe this is? The liquidity safe on Gnosis is already excluded from the circulating supply.

https://github.com/Giveth/giv-supply-function/blob/main/coingecko/index.js#L21

@laurenluz
Copy link
Member Author

@aminlatifi

  1. We have had like (e.g. honeyswap, ...) that still have giv staked there. They are there probably for trading purpose and are around 800k. So, @laurenluz do you still we must remove them?

Hm.. yes I think we can hide these. Because I think the main thing is we want to show GIV being staked in our GIV staking contracts... This other GIV, I'm assuming is something to do with liquidity? and we should represent that in another chart.

I'll let you figure out 3 w/ mitch there :)

@laurenluz
Copy link
Member Author

@aminlatifi I was thinking, it would also be really interesting to show:

  • how many unique addresses are hold GIV on Mainnet, Optimism, Gnosis, Solana (is Solana possible?)
  • how many unique addresses are staking GIV on Gnosis, Optimism

can we add those in too as simple stats?

@aminlatifi
Copy link
Member

@aminlatifi

  1. We have had like (e.g. honeyswap, ...) that still have giv staked there. They are there probably for trading purpose and are around 800k. So, @laurenluz do you still we must remove them?

Hm.. yes I think we can hide these. Because I think the main thing is we want to show GIV being staked in our GIV staking contracts... This other GIV, I'm assuming is something to do with liquidity? and we should represent that in another chart.

I'll let you figure out 3 w/ mitch there :)

I removed whole staking part so.

@aminlatifi
Copy link
Member

@aminlatifi Can you clarify which safe this is? The liquidity safe on Gnosis is already excluded from the circulating supply.

https://github.com/Giveth/giv-supply-function/blob/main/coingecko/index.js#L21

Sorry, I meant Gnosis Bridge (Mainnet -> xDAI bridge)
0x88ad09518695c6c3712ac10a214be5109a655671

@aminlatifi
Copy link
Member

Hey @aminlatifi I love the dashboard so far. Some feedback:

  1. let's hide the mainnet staking one... since we aren't really supporting that... so those GIV tokens are like... people forgot about them :-D
  2. Is there any real difference between the staked & givpower staking charts? because I think they are sort of redundant. We can remove the "staked" ones entirely because that important staking data is covered in the GIVpower staking charts
  3. Where did you get the mainnet circulating supply number from?
    We should expand circulating supplies to show:
  • total circulating supply (from the API): https://circulating.giveth.io/token-supply
  • GIV circulating on mainnet
  • GIV circulating on gnosis (from omni bridge - excluded addresses
  • GIV circulating on OP mainnet (from optimism bridge - excluded addresses)
  • GIV circulating on polygon zkevm (from polygon zkevm bridge - excluded addresses) --> this is probably 0 right now
  • GIV circulaing on solana (from wormhole bridge - excluded addresses)

When I say "excluded addresses" I basically mean the multisigs etc that Giveth owns that are not really "circulating GIV" (like the GIVgarden multisig)... this repo should have the info that is fed to that coingecko API: https://github.com/Giveth/giv-supply-function/

If you have any questions about those excluded addresses, @divine-comedian is the master here.

  1. small typo on active locked positions "gnosos" should be "gnosis"
    image
  2. For the GIVpower lock charts in general
  • I think they are interesting but I think we really want to show the actual unlock schedule... we want to see when a certain amount of GIVpower will be unlocked.... how much will be unlocked on each round end date, for example. Maybe we can represent this somehow?
  • We also want to show the total amount locked vs. amount staked... somehow... even just showing a % number... GIV locked (for any number of round) / GIV staked total.

@laurenluz This is made for 3
image

@aminlatifi
Copy link
Member

Hey @aminlatifi I love the dashboard so far. Some feedback:

  1. let's hide the mainnet staking one... since we aren't really supporting that... so those GIV tokens are like... people forgot about them :-D
  2. Is there any real difference between the staked & givpower staking charts? because I think they are sort of redundant. We can remove the "staked" ones entirely because that important staking data is covered in the GIVpower staking charts
  3. Where did you get the mainnet circulating supply number from?
    We should expand circulating supplies to show:
  • total circulating supply (from the API): https://circulating.giveth.io/token-supply
  • GIV circulating on mainnet
  • GIV circulating on gnosis (from omni bridge - excluded addresses
  • GIV circulating on OP mainnet (from optimism bridge - excluded addresses)
  • GIV circulating on polygon zkevm (from polygon zkevm bridge - excluded addresses) --> this is probably 0 right now
  • GIV circulaing on solana (from wormhole bridge - excluded addresses)

When I say "excluded addresses" I basically mean the multisigs etc that Giveth owns that are not really "circulating GIV" (like the GIVgarden multisig)... this repo should have the info that is fed to that coingecko API: https://github.com/Giveth/giv-supply-function/

If you have any questions about those excluded addresses, @divine-comedian is the master here.

  1. small typo on active locked positions "gnosos" should be "gnosis"
    image
  2. For the GIVpower lock charts in general
  • I think they are interesting but I think we really want to show the actual unlock schedule... we want to see when a certain amount of GIVpower will be unlocked.... how much will be unlocked on each round end date, for example. Maybe we can represent this somehow?
  • We also want to show the total amount locked vs. amount staked... somehow... even just showing a % number... GIV locked (for any number of round) / GIV staked total.

5 is implemented in this way
image
image

@aminlatifi
Copy link
Member

@aminlatifi I was thinking, it would also be really interesting to show:

  • how many unique addresses are hold GIV on Mainnet, Optimism, Gnosis, Solana (is Solana possible?)
  • how many unique addresses are staking GIV on Gnosis, Optimism

can we add those in too as simple stats?

Done,

image

@laurenluz
Copy link
Member Author

laurenluz commented May 28, 2024

Hey @aminlatifi I think some of these stats might have a mistake:

If you look on gnosis scan, I see 6286 holders: https://gnosisscan.io/token/0x4f4f9b8d5b4d0dc10506e5551b0513b61fd59e75#balances

but the dashboard shows less:
image

And for stakers on gnosis... shouldn't we look at the holders of POW? I see 783 on gnosis chain... https://gnosisscan.io/token/0xd93d3bdba18ebcb3317a57119ea44ed2cf41c2f2

but then the dashboard says there are more:
image

Similar issue w/ Optimism's POW (215 on block explorer but 197 on the dashboard) https://optimistic.etherscan.io/token/0x301c739cf6bfb6b47a74878bdeb13f92f13ae5e7

@laurenluz
Copy link
Member Author

laurenluz commented May 29, 2024

We also had another dashboard issue with requiremetns I think we can add to here... copy/pasting:

We basically want to know how much GIV is staked, locked & until when:

  • every 2 weeks, how much GIV can be unlocked?
  • how much GIV is staked and not locked?
  • how much GIV is locked for 1 year?
  • when are the big "unlock" moments - i.e. when will large amount of GIV get unlocked
  • % of total supply (GIV) that is staked
  • % of total supply (GIV) that is locked
  • % of total supply (GIV) that is locked for more than 6 months
  • value (in $) of GIV that's locked

I'm checking them off on the ones I think we covered. lmk also what you think @aminlatifi

@aminlatifi
Copy link
Member

image

I computed tokens will be unlocked after 6 month for "% of total supply (GIV) that is locked for more than 6 months"

@aminlatifi
Copy link
Member

Trying to find a way to have GIV token price in Dune,
Made this but it doesn't work duneanalytics/spellbook#6137
We have to make GIV listed in CoinPaprika
https://coinpaprika.com/

@aminlatifi
Copy link
Member

Trying to find a way to have GIV token price in Dune, Made this but it doesn't work duneanalytics/spellbook#6137 We have to make GIV listed in CoinPaprika https://coinpaprika.com/

cc @laurenluz

@laurenluz
Copy link
Member Author

The portion of staked tokens in GIVPower which are locked

@aminlatifi can you change the title of this chart then from "GIVPower All locked percentage" to "Percentage of staked GIV that is locked"

Is it what you want?
image

Not quite. Instead of a bar graph, can you just put titles & straight numbers? The bar graph is confusing because the numbers aren't really related to each other. so we should just put:

% of GIV Total Supply that is staked: z%
% of GIV Total Supply that is locked: x%
% of GIV Total Supply that is locked for at least 6 more months: y%

Simply titles & numbers (instead of a graph), similar to how we should the "number of GIV holders".

@laurenluz
Copy link
Member Author

DAO vs User balance holders image

Can we make this into one single pie chart @aminlatifi - let's not break it up per chain, but we should show 3 parts basically "Held by Giveth" "Help by users" "Streaming from Token distro"

@laurenluz
Copy link
Member Author

laurenluz commented Jun 24, 2024

For bottom part copy/aestheic fixes:

  • Remove subtitle "GIVpower Staking"
  • Remove subtitle "GIVpower Lock"
  • Change copy "history of lock positions" title to "History of locked GIV", remove secondary title
  • x-axis title, change copy from "number of lock rounds" to "Number of Rounds"
  • Change copy "Active Lock positions" title to "GIV Locked Now"
  • y-axis title, change copy to "GIV"
  • x-axis title, change copy to "Number of Rounds"
  • Change copy "unlock time" title to "GIV Unlock Times", remove secondary title
  • add y-axis title "GIV"

@aminlatifi
Copy link
Member

aminlatifi commented Jun 25, 2024

@laurenluz I assume all of these except the "Token Distro" ones must be listed. Do you confirm?

var mainnet_sc = [
  "0x87dE995F6744B75bBe0255A973081142aDb61f4d", // Token Distro
  "0xf924fF0f192f0c7c073161e0d62CE7635114e74f", // Liquidity Safe
  "0x2B0ee142dCFE7C2dD150cDbd7B6832F6e9977f51", // OneGIV Liquidity Multisig
];


var xdai_sc = [
  "0xc0dbDcA66a0636236fAbe1B3C16B1bD4C84bB1E1", // Token Distro
  "0xe70494225312c6b1167c15134dab66730f36708d", // Giveth Treasury
  "0xf4ef9a155dd268e321afa7b9391e0602a7b09588", // GIVgarden Common Pool
  "0xf924fF0f192f0c7c073161e0d62CE7635114e74f", // Liquidity Safe
  "0xd10BAC02a02747cB293972f99981F4Faf78E1626", // GIVgarden Multisig Wallet
];


var optimism_sc = [
  '0xE3Ac7b3e6B4065f4765d76fDC215606483BF3bD1', // Token Distro
  '0xf924fF0f192f0c7c073161e0d62CE7635114e74f', // Liquidity Safe
]

Yes this looks good.

@laurenluz For supporting the GIV program on solana, we need fill this form
https://docs.google.com/forms/d/e/1FAIpQLSfRTqD7C37y7VuyUTd4yZGoQmyPQZGyg3CnNcq1EPhmNZkLPA/viewform
For that I need GIV Solana program address.
I don't know who wormwhole bridge works, there are 2.8M GIV already in this 0x1D68124e65faFC907325e3EDbF8c4d84499DAa8b contract, is it wormwhole? If yes we must exclude it from OP Circulating supply

This form is coming from dune and allows us to get Solana info? Griff said that all the GIV tokens that end up Solana came through the wormhole bridge, and yeah! I think 0x1D68124e65faFC907325e3EDbF8c4d84499DAa8b this is it. the 2.8M GIV is what he "bridged" from OP to Solana, and this is all the GIV liquidity that exists on Solana.

So yes, I think we can exclude this from OP circulating supply and say "Solana circulating supply" is just whatever GIV is held in the wormhole bridge.

@laurenluz Regarding TVL, do we have any staking/locking platform on Mainnet?! I didn't find any.

We don't! We used to have a unipool contract for GIV staking on Mainnet (I think you can find it "deployment") but it was ended/archived a long time ago. there may be a bit of TVL in there, but I think perhaps not worth mentioning. what do you think?

Yes, the form comes from dune.
I added the solana circulating supply and excluded wormhole balance from op circulating supply. Also, I submitted the form with the info of GIV token on solana, I hope it gets accepted.
I agree, we can ignore Mainnet tvl part

@laurenluz
Copy link
Member Author

perfect! Thanks @aminlatifi - ping me once you address the other comments, I feel we are so close on this!!!

@aminlatifi
Copy link
Member

% of GIV Total Supply that is locked for at least 6 more months

image Done

@aminlatifi
Copy link
Member

@laurenluz Let's giv token on solana be supported on dune, then we can figure it out whether we can have number of holders on solana.

It's not possible to remove “All” labels.

What about NextGIV?! and new connect pools and routers? how do we want to treat them? Will tokens used to generate NextGIV on mainnet be included in the TVL?!

@aminlatifi
Copy link
Member

Hey @aminlatifi - how much would it cost to expedite our coinpaprika price discovery? maybe it's worth paying to not wait a month.

Beyond that, I spent some time going through to finalize the requirments and I have 2 parts... "new sections we should add" and "edits to existing sections".

I'll post right now the "new sections" here so you could start working on them if you have the time and will leave a follow up comment w/ edit requests so we can polish this off.

New Parts

  1. GIV liquidity
  • Show GIV liquidity (TVL) on Mainnet, Gnosis, and OP Mainnet (as three separate numbers/sections).
  • We should show the total liquidity on each chain, and then the % owned by the DAO, and % owned by others. Maybe this can be pie-chart format… with one pie chart corresponding to each chain.
  • You can get the major GIV liquidity pools from CoinGecko. They are basically all there, we are just missing the TEC/GIV one on OP Mainnet. And we will soon add a GIV/USDGLO pool on OP Mainnet (@divine_comedian is setting it up).
  • We should show the TVL as a single number denominated in GIV… so like.. .the total liquidity that exists in on that chain (in GIV), and separately show what that is in USD (assuming we can get the price :-D)
  1. DAO GIV holdings
  • We should show how much GIV is held by the DAO. I think this can be one number, and summed up from all chains. It should include basically all the multisigs/addresses we “excluded” from our circulating supply API (but shouldn’t include the GIV that is yet to be streamed from the token distro).
  • This is basically the GIV that’s held (on all chains) in the liquidity multisig, nrGIV DAO & multisig, and GIVgarden multisig (and not the streaming parts).
  1. GIV in the GIVstream
  • To show the user that we are accounting for all the GIV, the total circulating supply + DAO GIV holdings + GIVstream amount should equal 1 billion.
  • This should just be a single number (in GIV) that represents the amount of GIV that is still being streaming from the token distro on all chains… I think we can get it through simple math… 1 Billion - circulating supply - DAO GIV holdings = the number we want, but if you want to grab if from the distro contracts on-chain, that’s ok too! (It might help us double check our math).

Let me know if you have any questions on those parts. I'm working on a checklist for copy/small edits for existing parts.

image

@laurenluz I noticed the tally doesn't match 1B, it's 998,350k GIV almost
After investigation, I noticed there is imbalance between two sides of gnosis omnibridge. This gnosis token bridge has kept 1,647k of GIV for fee or something else.

@laurenluz
Copy link
Member Author

image

Can we remove the titles here that say "Staked Total Supply" etc.? the big names below the numbers. I think it makes things more confusing to have them there. The titles at the top of the box are enough.

What about NextGIV?! and new connect pools and routers? how do we want to treat them? Will tokens used to generate NextGIV on mainnet be included in the TVL?!

So I think from what we decided in the GIVeconomy call today, the nextGIV and all that bridge liqudity for connext, we should consider as circulating. and also we should count the bridge liqudity in our liqudity TVL section (that we discussed adding/expanding today).

@laurenluz I found a GIV/Matic uniswapv3 pool on mainnet having over 6M GIV
https://etherscan.io/address/0x46ad345fff4aec9990a4f20e829c50fbf291db0e#readContract

Another
GIV/ETH having over 3M GIV
https://etherscan.io/address/0xc763b6b3d0f75167db95daa6a0a0d75dd467c4e1

FOX/GIV over 3M GIV
https://etherscan.io/address/0xad0e10df5dcdf21396b9d64715aadaf543f8b376

Connext bridge over 3M GIV
https://etherscan.io/address/0x8898b472c54c31894e3b9bb83cea802a5d0e63c6

A gnosis safe with over 1.3M GIV
https://etherscan.io/address/0x7e5013302dc94c1efa6632aaf6f542251e146a81#code

More mainnet givholders (excluded known bridges and tokdn distro)
https://dune.com/queries/3864568?category=decoded_project&namespace=giv&contract=GIV&blockchains=ethereum&id=giv_ethereum.GIV_evt_Transfer

We should include all those GIV/MATIC GIV/ETH FOX/GIV and Connext bridge in the liquidity TVL part.

I'm checking with Griff and mitch what is this safe

@laurenluz I noticed the tally doesn't match 1B, it's 998,350k GIV almost
After investigation, I noticed there is imbalance between two sides of gnosis omnibridge. This gnosis token bridge has kept 1,647k of GIV for fee or something else.

So from what we decided in the GIVeconomy call, since all the tokens on gnosis originally came from mainnet through the onmi bridge... you should just subtract the gnosis circulating supply from whatever is in the onmi bridge on mainnet.. and then we also know what is the mainnet circulating supply. Any tokens that are on the mainnet side but not claimed out of the mainnet bridge are then considered as part of mainnet circulating supply.

@aminlatifi
Copy link
Member

aminlatifi commented Jul 1, 2024

0x8898b472c54c31894e3b9bb83cea802a5d0e63c6

All are done, the TVL section is like below
image

For gnosis, I find a way to include all GIV token hold in every honeyswap, sushiswap and balancer pools! so I didn't pick few like GIV/ETH etc.
Also for mainnet, I added whole give in balancer (includes every balancer pools) as TVL

UPDATE: I added all uniswapv3 pools liquidity to mainnet and op mainnet tvls

@aminlatifi
Copy link
Member

@laurenluz Regarding below, I couldn't find any veldorme pool to add to op mainnet tvl

You can get the major GIV liquidity pools from CoinGecko. They are basically all there, we are just missing the TEC/GIV one on OP Mainnet. And we will soon add a GIV/USDGLO pool on OP Mainnet (@divine_comedian is setting it up).
We should show the TVL as a single number denominated in GIV… so like.. .the total liquidity that exists in on that chain (in GIV), and separately show what that is in USD (assuming we can get the price :-D)

@laurenluz
Copy link
Member Author

@aminlatifi - The GIV/USDGLO pair was set up on Uniswap v2 on OP Mainnet.

@laurenluz
Copy link
Member Author

@aminlatifi on these:
image

  • the $ should be before the number (not after)
  • can you also should the TVL amount in GIV - maybe show this number below/smaller?

@aminlatifi
Copy link
Member

@aminlatifi - The GIV/USDGLO pair was set up on Uniswap v2 on OP Mainnet.

Are you sure? do you have any sample swap tx? or pool address? I couldn't find any!

@aminlatifi
Copy link
Member

@aminlatifi on these: image

  • the $ should be before the number (not after)
  • can you also should the TVL amount in GIV - maybe show this number below/smaller?

Changed the $ position.
No, the component doesn't support that! we must create another counter if we need

@aminlatifi
Copy link
Member

@aminlatifi - The GIV/USDGLO pair was set up on Uniswap v2 on OP Mainnet.

Done, now all optimism uniswapV2 pools will be supported automatically.

@laurenluz
Copy link
Member Author

Ok aweomse. Griff mentioned also last time that we should show the % of the TVL that is "DAO owned" - Do you need some guidance on how to do that @aminlatifi ?

A lot that liquidity that we have, the LPs are held by the liquidity multisig on various chains. I think we can consider that all to be "DAO-owned", and then the GIV that we bridged to Solana and provided liquiidty with... I think Griff might hold those LP tokens, but that's the only weird one I can think of.

@aminlatifi
Copy link
Member

aminlatifi commented Jul 16, 2024

Ok aweomse. Griff mentioned also last time that we should show the % of the TVL that is "DAO owned" - Do you need some guidance on how to do that @aminlatifi ?

A lot that liquidity that we have, the LPs are held by the liquidity multisig on various chains. I think we can consider that all to be "DAO-owned", and then the GIV that we bridged to Solana and provided liquiidty with... I think Griff might hold those LP tokens, but that's the only weird one I can think of.

Do you know on which pools DAO has liquidity? it matters since for example computation would be different for uniswap and balancer. If all are uniswapv2 it probably would be simple. But other ones like uniswapv3 and balancer I am afraid not.

@laurenluz
Copy link
Member Author

laurenluz commented Jul 17, 2024

I think it's going to get too complicated and we can skip it. Went through this once more with Griff, and got some final comments/change requests.

  • "Stream balance "title should be "Locked in GIVstream"
  • Remove "GIV balance holders" pie charts for chains mainnet, gnosis, OP.. keep only GIV balance holders or "all chains"
  • GIV balance holders "all chains" pie chart should be changed to show only a % number with the title "% of Circulating Supply Held by the DAO"
  • "Unique GIV Holders" titles should be changed to "Unique GIV Holders & Stakers"
  • Change titles of TVL to "Liquidity in DEXs"... e.g. "Mainnet GIV Liquidity in DEXs" (change for all chains)
  • GIVpower section "% of total supply that is locked" should actually show the "% of Circulating Supply that is Locked" (maybe we need to change the logic?)
  • % of GIV Total Supply that is staked should be "% of GIV Circulating Supply that is staked" (maybe we need to change the logic?)
  • "% of GIV Total Supply that is locked for at least 6 more months" should be "% of GIV Circulating Supply that is locked for at least 6 more months" (maybe we need to change the logic?)
  • Griff wants you to change ange colors of "giv locked now" to green & red
  • There is a mistake in GIV unlock times chart! Some people definitely are locking until Jun 2025 on OP Mainnet, but the chart is not saying they are.
  • "Lock GIV value" The "$" should be at the beginning of the number... and we should remove the title that is below the number... so there is only one title.

Omg and I think that should be it.

@laurenluz
Copy link
Member Author

image

@laurenluz
Copy link
Member Author

laurenluz commented Jul 17, 2024

Ok @aminlatifi so to summarize, there are 5 query changes that we need:

  • GIV balance holders "all chains" pie chart should be changed to show only a % number with the title "% of Circulating Supply Held by the DAO"
  • GIVpower section "% of total supply that is locked" should actually show the "% of Circulating Supply that is Locked"
  • % of GIV Total Supply that is staked should be "% of GIV Circulating Supply that is staked"
  • % of GIV Total Supply that is locked for at least 6 more months" should be "% of GIV Circulating Supply that is locked for at least 6 more months"
  • There is a mistake in GIV unlock times chart! Some people definitely are locking until Jun 2025 on OP Mainnet, but the chart is not saying they are (see my image above of my lockup dates)

@aminlatifi
Copy link
Member

Ok @aminlatifi so to summarize, there are 5 query changes that we need:

  • GIV balance holders "all chains" pie chart should be changed to show only a % number with the title "% of Circulating Supply Held by the DAO"
  • GIVpower section "% of total supply that is locked" should actually show the "% of Circulating Supply that is Locked"
  • % of GIV Total Supply that is staked should be "% of GIV Circulating Supply that is staked"
  • % of GIV Total Supply that is locked for at least 6 more months" should be "% of GIV Circulating Supply that is locked for at least 6 more months"
  • There is a mistake in GIV unlock times chart! Some people definitely are locking until Jun 2025 on OP Mainnet, but the chart is not saying they are (see my image above of my lockup dates)

These are done, @laurenluz please double check.

@aminlatifi
Copy link
Member

There is a mistake in GIV unlock times chart! Some people definitely are locking until Jun 2025 on OP Mainnet, but the chart is not saying they are (see my image above of my lockup dates)

I fixed that, The Optimism givpower contract has a different init date than the gnosis one and I didn't know.
Fixed that issue in the below diagram as well.

image

@laurenluz
Copy link
Member Author

@aminlatifi - I removed the pie chart for % of GIV held by the DAO and replaced it with just a number instead. I think I did this right! Lmk if it looks ok? I just added a new visualization to your query, then deleted the pie chart and add the counter to the dashboard.

Before:
image

After:
image

Also, on these three numbers... Shouldn't they add to a total of 1 Billion? They actually add to a bit more than that, I think we might be double counting somewhere - can you check?

image

@aminlatifi
Copy link
Member

@aminlatifi - I removed the pie chart for % of GIV held by the DAO and replaced it with just a number instead. I think I did this right! Lmk if it looks ok? I just added a new visualization to your query, then deleted the pie chart and add the counter to the dashboard.

Before: image

After: image

Also, on these three numbers... Shouldn't they add to a total of 1 Billion? They actually add to a bit more than that, I think we might be double counting somewhere - can you check?

image

That counter is fine.

They had different query execution time, I refresh them all now the tally match
image

@laurenluz
Copy link
Member Author

EXCELLENT!!!!! Ok I'm asking for feedback from others on this, but from my view, this is GREAT!!! THANK YOUUUUUUUUU

@laurenluz
Copy link
Member Author

Feels like a MAJOR achievement to close this issue https://dune.com/giveconomy/giveconomy

Praise you @aminlatifi !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Progress P2 A normal to do item or feature.
Projects
Status: Done
Development

No branches or pull requests

7 participants