-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GIV liquidity dune dashboard #2420
Comments
@alireza-sharifpour - can you take this? @RamRamez is working on the other GIVpower one in #2419 |
Yes, I'll work on it. @laurenluz |
I've migrated the Honeyswap query data to new Dune v2: |
@aminlatifi I hear you are starting to work on this! This issue is a year old at this point, so although the things mentioned are still good, I have some more context/desires for you... The purpose of this dashboard is to give an at-a-glance picture of what is going on with the GIVeconomy. Where do we have liquidity, where is the GIV held, who is holding it? I spoke w/ Griff about it and some points we'd want are:
I think you can get started with this, and then ask questions as you go along. If you need help searching for link to our liquidity pools or other "Where is the GIV" things, I can help w/ that and we can also discuss in the GIVeconomy calls. You may even know some things I missed :) |
The Dune query engine has changed, and we must create optimized queries to manage our free credit for a month. I could create queries to run in a short time and place them here https://dune.com/aminlatifi/giveconomy |
Hey @aminlatifi I love the dashboard so far. Some feedback:
When I say "excluded addresses" I basically mean the multisigs etc that Giveth owns that are not really "circulating GIV" (like the GIVgarden multisig)... this repo should have the info that is fed to that coingecko API: https://github.com/Giveth/giv-supply-function/ If you have any questions about those excluded addresses, @divine-comedian is the master here.
|
The excluded addresses applied to our circulating supply endpoint are found here and are clearly labelled |
|
@aminlatifi Can you clarify which safe this is? The liquidity safe on Gnosis is already excluded from the circulating supply. https://github.com/Giveth/giv-supply-function/blob/main/coingecko/index.js#L21 |
Hm.. yes I think we can hide these. Because I think the main thing is we want to show GIV being staked in our GIV staking contracts... This other GIV, I'm assuming is something to do with liquidity? and we should represent that in another chart. I'll let you figure out 3 w/ mitch there :) |
@aminlatifi I was thinking, it would also be really interesting to show:
can we add those in too as simple stats? |
I removed whole staking part so. |
Sorry, I meant Gnosis Bridge (Mainnet -> xDAI bridge) |
@laurenluz This is made for 3 |
|
Done, ![]() |
Hey @aminlatifi I think some of these stats might have a mistake: If you look on gnosis scan, I see 6286 holders: https://gnosisscan.io/token/0x4f4f9b8d5b4d0dc10506e5551b0513b61fd59e75#balances And for stakers on gnosis... shouldn't we look at the holders of POW? I see 783 on gnosis chain... https://gnosisscan.io/token/0xd93d3bdba18ebcb3317a57119ea44ed2cf41c2f2 but then the dashboard says there are more: Similar issue w/ Optimism's POW (215 on block explorer but 197 on the dashboard) https://optimistic.etherscan.io/token/0x301c739cf6bfb6b47a74878bdeb13f92f13ae5e7 |
We also had another dashboard issue with requiremetns I think we can add to here... copy/pasting: We basically want to know how much GIV is staked, locked & until when:
I'm checking them off on the ones I think we covered. lmk also what you think @aminlatifi |
Trying to find a way to have GIV token price in Dune, |
cc @laurenluz |
@aminlatifi can you change the title of this chart then from "GIVPower All locked percentage" to "Percentage of staked GIV that is locked" Not quite. Instead of a bar graph, can you just put titles & straight numbers? The bar graph is confusing because the numbers aren't really related to each other. so we should just put: % of GIV Total Supply that is staked: z% Simply titles & numbers (instead of a graph), similar to how we should the "number of GIV holders". |
Can we make this into one single pie chart @aminlatifi - let's not break it up per chain, but we should show 3 parts basically "Held by Giveth" "Help by users" "Streaming from Token distro" |
For bottom part copy/aestheic fixes:
|
Yes, the form comes from dune. |
perfect! Thanks @aminlatifi - ping me once you address the other comments, I feel we are so close on this!!! |
@laurenluz Let's giv token on solana be supported on dune, then we can figure it out whether we can have number of holders on solana. It's not possible to remove “All” labels. What about NextGIV?! and new connect pools and routers? how do we want to treat them? Will tokens used to generate NextGIV on mainnet be included in the TVL?! |
@laurenluz I found a GIV/Matic uniswapv3 pool on mainnet having over 6M GIV Another FOX/GIV over 3M GIV Connext bridge over 3M GIV A gnosis safe with over 1.3M GIV More mainnet givholders (excluded known bridges and tokdn distro) |
![]() @laurenluz I noticed the tally doesn't match 1B, it's 998,350k GIV almost |
Can we remove the titles here that say "Staked Total Supply" etc.? the big names below the numbers. I think it makes things more confusing to have them there. The titles at the top of the box are enough.
So I think from what we decided in the GIVeconomy call today, the nextGIV and all that bridge liqudity for connext, we should consider as circulating. and also we should count the bridge liqudity in our liqudity TVL section (that we discussed adding/expanding today).
We should include all those GIV/MATIC GIV/ETH FOX/GIV and Connext bridge in the liquidity TVL part. I'm checking with Griff and mitch what is this safe
So from what we decided in the GIVeconomy call, since all the tokens on gnosis originally came from mainnet through the onmi bridge... you should just subtract the gnosis circulating supply from whatever is in the onmi bridge on mainnet.. and then we also know what is the mainnet circulating supply. Any tokens that are on the mainnet side but not claimed out of the mainnet bridge are then considered as part of mainnet circulating supply. |
@laurenluz Regarding below, I couldn't find any veldorme pool to add to op mainnet tvl
|
@aminlatifi - The GIV/USDGLO pair was set up on Uniswap v2 on OP Mainnet. |
@aminlatifi on these:
|
Are you sure? do you have any sample swap tx? or pool address? I couldn't find any! |
Changed the $ position. |
Done, now all optimism uniswapV2 pools will be supported automatically. |
Ok aweomse. Griff mentioned also last time that we should show the % of the TVL that is "DAO owned" - Do you need some guidance on how to do that @aminlatifi ? A lot that liquidity that we have, the LPs are held by the liquidity multisig on various chains. I think we can consider that all to be "DAO-owned", and then the GIV that we bridged to Solana and provided liquiidty with... I think Griff might hold those LP tokens, but that's the only weird one I can think of. |
Do you know on which pools DAO has liquidity? it matters since for example computation would be different for uniswap and balancer. If all are uniswapv2 it probably would be simple. But other ones like uniswapv3 and balancer I am afraid not. |
I think it's going to get too complicated and we can skip it. Went through this once more with Griff, and got some final comments/change requests.
Omg and I think that should be it. |
Ok @aminlatifi so to summarize, there are 5 query changes that we need:
|
These are done, @laurenluz please double check. |
@aminlatifi - I removed the pie chart for % of GIV held by the DAO and replaced it with just a number instead. I think I did this right! Lmk if it looks ok? I just added a new visualization to your query, then deleted the pie chart and add the counter to the dashboard. Also, on these three numbers... Shouldn't they add to a total of 1 Billion? They actually add to a bit more than that, I think we might be double counting somewhere - can you check? |
That counter is fine. They had different query execution time, I refresh them all now the tally match |
EXCELLENT!!!!! Ok I'm asking for feedback from others on this, but from my view, this is GREAT!!! THANK YOUUUUUUUUU |
Feels like a MAJOR achievement to close this issue https://dune.com/giveconomy/giveconomy Praise you @aminlatifi !! |
We have this awesome GIVeconomy dashboard that was made by Fabio, but it is very out of date: https://dune.com/metacrypto/giveconomy
It would be great to fork this dashboard & add to it so that we can show GIV liquidity on multiple chains, and show what is owned by the DAO, and what is provided by individuals.
Would be great to show:
This would be valueable to show to people who are interested in GIV & its stability. (like investors)
@RamRamez
It would be nice to build in dune because it uses on chain data, and then has network effects - it can easily be forked and used by others.
The text was updated successfully, but these errors were encountered: