New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get dynamic emails #12

Merged
merged 8 commits into from Sep 18, 2016

Conversation

Projects
None yet
2 participants
@amitaibu
Member

amitaibu commented Sep 18, 2016

elm

@amitaibu

This comment has been minimized.

Show comment
Hide comment
@amitaibu

amitaibu Sep 18, 2016

Member

Elm is amazing. When it compiled, it worked!

ezgif com-video-to-gif 7

Member

amitaibu commented Sep 18, 2016

Elm is amazing. When it compiled, it worked!

ezgif com-video-to-gif 7

amitaibu added some commits Sep 18, 2016

@amitaibu

This comment has been minimized.

Show comment
Hide comment
@amitaibu

amitaibu Sep 18, 2016

Member

update: Once tests return green, the next step would be to add the options for the user to select from.

@IshaDakota can you add some markup in the static of how this should look.

Member

amitaibu commented Sep 18, 2016

update: Once tests return green, the next step would be to add the options for the user to select from.

@IshaDakota can you add some markup in the static of how this should look.

@amitaibu

This comment has been minimized.

Show comment
Hide comment
@amitaibu

amitaibu Sep 18, 2016

Member

Tests are passing locally, so not waiting for travis.

Member

amitaibu commented Sep 18, 2016

Tests are passing locally, so not waiting for travis.

@amitaibu amitaibu merged commit 63dfeea into master Sep 18, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@amitaibu

This comment has been minimized.

Show comment
Hide comment
@amitaibu

amitaibu Sep 18, 2016

Member

@IshaDakota can you add some markup in the static of how this should look.

(In a follow up PR that is)

Member

amitaibu commented Sep 18, 2016

@IshaDakota can you add some markup in the static of how this should look.

(In a follow up PR that is)

@amitaibu amitaibu deleted the dynamic-emails branch Sep 18, 2016

@adamhstewart

This comment has been minimized.

Show comment
Hide comment
@adamhstewart

adamhstewart Sep 18, 2016

Member

@amitaibu do you mean things like hover behavior, and fine details like that? Otherwise I think you nailed it.

Member

adamhstewart commented Sep 18, 2016

@amitaibu do you mean things like hover behavior, and fine details like that? Otherwise I think you nailed it.

@amitaibu

This comment has been minimized.

Show comment
Hide comment
@amitaibu

amitaibu Sep 18, 2016

Member

Just the radios. So no follow up needed.

Member

amitaibu commented Sep 18, 2016

Just the radios. So no follow up needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment