From 1bf37991260f6905b7fe900799f71aca286e5f97 Mon Sep 17 00:00:00 2001
From: Romain Hugonnet <romain.hugonnet@gmail.com>
Date: Fri, 7 Jun 2024 07:38:15 -0800
Subject: [PATCH] Account for amaurys comments

---
 tests/test_coreg/test_base.py | 6 ++++--
 xdem/coreg/base.py            | 1 +
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/test_coreg/test_base.py b/tests/test_coreg/test_base.py
index 70c332c9..624a2f99 100644
--- a/tests/test_coreg/test_base.py
+++ b/tests/test_coreg/test_base.py
@@ -921,7 +921,7 @@ class TestAffineManipulation:
     e = np.deg2rad(np.array([rotation_x, rotation_y, rotation_z]))
     # This is a 3x3 rotation matrix
     rot_matrix = pytransform3d.rotations.matrix_from_euler(e=e, i=0, j=1, k=2, extrinsic=True)
-    matrix_all = matrix_rotations
+    matrix_all = matrix_rotations.copy()
     matrix_all[0:3, 0:3] = rot_matrix
     matrix_all[:3, 3] = [0.5, 1, 1.5]
 
@@ -1004,7 +1004,8 @@ def test_apply_matrix__raster_nodata(self) -> None:
         # The iterative mask should be larger and contain the other (as griddata interpolates up to 1 pixel away)
         assert np.array_equal(np.logical_or(mask_nodata_gd, mask_nodata_it), mask_nodata_it)
 
-        # Verify nodata masks are located within two pixels of each other
+        # Verify nodata masks are located within two pixels of each other (1 pixel can be added by griddata,
+        # and 1 removed by regular-grid interpolation by the iterative method)
         smallest_mask = ~binary_dilation(
             ~mask_nodata_it, iterations=2
         )  # Invert before dilate to avoid spreading at the edges
@@ -1019,6 +1020,7 @@ def test_apply_matrix__raster_realdata(self) -> None:
         dem.crop((dem.bounds.left, dem.bounds.bottom, dem.bounds.left + 2000, dem.bounds.bottom + 2000))
         epc = dem.to_pointcloud(data_column_name="z").ds
 
+        # Only testing complex matrices for speed
         matrix = self.matrix_all
 
         # If a centroid was not given, default to the center of the DEM (at Z=0).
diff --git a/xdem/coreg/base.py b/xdem/coreg/base.py
index 2d572101..94b1ab3f 100644
--- a/xdem/coreg/base.py
+++ b/xdem/coreg/base.py
@@ -846,6 +846,7 @@ def _iterate_affine_regrid_small_rotations(
     # fall exactly on regular X,Y coordinates
 
     # 1/ The elevation of the original DEM, Z', is simply a 2D interpolator function of X',Y' (bilinear, typically)
+    # (We create the interpolator only once here for computational speed, instead of using Raster.interp_points)
     xycoords = dem_rst.coords(grid=False)
     z_interp = scipy.interpolate.RegularGridInterpolator(
         points=(np.flip(xycoords[1], axis=0), xycoords[0]), values=dem, method=resampling, bounds_error=False