Withings Service

[euguuu]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
• If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
• If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
• If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

This PR is an integration of withings devices.
Only measures are synchronize in gladys now (not activities, workout, sleep event).
It's possible to integrate only 1 withings user for the moment.

I test in real life with device named 'Body' but normaly works with all withings devices.

Video of integration step:
https://user-images.githubusercontent.com/9742965/145620064-274b1b89-2348-4cc3-a53d-536eb7f99958.mp4

example of results in chart:

[codecov]

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (bf8716f) 97.94% compared to head (48492a9) 97.99%.
Report is 61 commits behind head on master.

Files	Patch %	Lines
.../withings/lib/oauth2-client/oauth2.executeQuery.js	91.11%	4 Missing ⚠️
...ithings/lib/oauth2-client/oauth2.getAccessToken.js	85.71%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1399      +/-   ##
==========================================
+ Coverage   97.94%   97.99%   +0.04%     
==========================================
  Files         748      773      +25     
  Lines       11580    12066     +486     
==========================================
+ Hits        11342    11824     +482     
- Misses        238      242       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Pierre-Gilles]

Hello!

Thanks for your PR, and happy new year!

I just came back from holidays and did a first general review of this PR.

I would be interested to see a demo video of the integration?

Good job 👏

[relativeci]

Job #1919: Bundle Size — 9.26MiB (+4.95%).

48492a9(current) vs c87e90f master#1917(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics   5 changes 2 regressions

	Current Job #1919	Baseline Job #1917
Initial JS	4.82MiB(+1.12%)	4.77MiB
Initial CSS	301.39KiB(+0.03%)	301.31KiB
Cache Invalidation	58.01%	0%
Chunks	48	48
Assets	174(+14.47%)	152
Modules	1392(+1.09%)	1377
Duplicate Modules	19	19
Duplicate Code	0.69%	0.69%
Packages	124	124
Duplicate Packages	3	3

Bundle size by type   4 changes 4 regressions

	Current Job #1919	Baseline Job #1917
JS	6.44MiB (+0.9%)	6.39MiB
IMG	2.38MiB (+18.84%)	2MiB
CSS	317.05KiB (+0.03%)	316.97KiB
Fonts	93.55KiB	93.55KiB
Other	17.44KiB (+12.63%)	15.48KiB
HTML	13.58KiB	13.58KiB

---

View job #1919 report View euguuu:withings-only branch activity

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.