Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1426: Fix critical bug in Zigbee2mqtt integration that could slow down the Gladys instance in case a message is not converted #1427

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

cicoub13
Copy link
Contributor

@cicoub13 cicoub13 commented Feb 3, 2022

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fix the issue. Didn't test with real device

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #1427 (1075d5e) into master (cfee2ac) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1427      +/-   ##
==========================================
- Coverage   96.55%   96.54%   -0.02%     
==========================================
  Files         613      613              
  Lines        8747     8749       +2     
==========================================
+ Hits         8446     8447       +1     
- Misses        301      302       +1     
Impacted Files Coverage Δ
...rver/services/zigbee2mqtt/lib/handleMqttMessage.js 100.00% <100.00%> (ø)
server/lib/scene/scene.addScene.js 92.59% <0.00%> (-1.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfee2ac...1075d5e. Read the comment docs.

@cicoub13
Copy link
Contributor Author

cicoub13 commented Feb 3, 2022

I don't know why the coverage is lower on scene.addScene.js 🤔

@cicoub13
Copy link
Contributor Author

cicoub13 commented Feb 3, 2022

Fixes #1426 (I forgot in my commit 😞)

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

The addScene issue seems to be a mistake from codecov, I don't see why it could be linked.

Thanks for the quick PR :)

@Pierre-Gilles Pierre-Gilles merged commit 77c9755 into GladysAssistant:master Feb 3, 2022
@relativeci
Copy link

relativeci bot commented Feb 3, 2022

Job #181: Bundle Size — 6.67MB (0%).

77c9755 vs cfee2ac

No changes


View Job #181 report on app.relative-ci.com

@Pierre-Gilles Pierre-Gilles changed the title Fix 1426 Fix 1426: Fix critical bug in Zigbee2mqtt integration that could slow down the Gladys instance in case a message is not converted Feb 7, 2022
@cicoub13 cicoub13 deleted the fix-1426 branch May 23, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants