Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add charts-history feature #2091

Closed
wants to merge 12 commits into from

Conversation

Terdious
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@Terdious Terdious changed the title Add charts-history feature and related components and styles [WIP] Add charts-history feature and related components and styles May 27, 2024
Copy link

relativeci bot commented May 27, 2024

#2594 Bundle Size — 12.07MiB (+19.12%).

cc73a5b(current) vs 09a7987 master#2576(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Warning

Bundle introduced 2 new packages: xlsx-js-style, sweetalert2 – View changed packages

Bundle metrics  Change 9 changes Regression 4 regressions
                 Current
#2594
     Baseline
#2576
Regression  Initial JS 7.38MiB(+35.22%) 5.46MiB
Regression  Initial CSS 305.06KiB(+0.69%) 302.96KiB
Change  Cache Invalidation 70.6% 63.14%
Change  Chunks 53(+3.92%) 51
Change  Assets 172(+1.18%) 170
Change  Modules 1506(+1.76%) 1480
Regression  Duplicate Modules 22(+4.76%) 21
Change  Duplicate Code 0.75%(-8.54%) 0.82%
Regression  Packages 126(+1.61%) 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
#2594
     Baseline
#2576
Regression  JS 9.17MiB (+26.75%) 7.24MiB
No change  IMG 2.46MiB 2.46MiB
Regression  CSS 321.85KiB (+0.66%) 319.75KiB
No change  Fonts 93.55KiB 93.55KiB
Regression  Other 17.86KiB (+1.91%) 17.53KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch Terdious:add-view-chartsProject dashboard

***Add charts-history link to header***
***Add style for EditBox and EmptyColumnDropZone***
***Update createDashboard button text***
***Add EmptyColumnDropZone and BottomDropZone components***
***Add routes for charts history pages
***Remove unused import***

***Update dashboard retrieval***

***Update device features retrieval***

***Update language files***

***Update device controller
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 35.48387% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 98.12%. Comparing base (09a7987) to head (a5a2b64).

Current head a5a2b64 differs from pull request most recent head cc73a5b

Please upload reports for the commit cc73a5b to get more accurate results.

Files Patch % Lines
...erver/lib/device/device.getDeviceFeaturesStates.js 22.85% 27 Missing ⚠️
...r/lib/device/device.getDeviceFeaturesAggregates.js 37.50% 10 Missing ⚠️
.../lib/device/device.getDeviceFeaturesStatesMulti.js 50.00% 2 Missing ⚠️
server/api/controllers/device.controller.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2091      +/-   ##
==========================================
- Coverage   98.40%   98.12%   -0.29%     
==========================================
  Files         858      860       +2     
  Lines       14081    14141      +60     
==========================================
+ Hits        13857    13876      +19     
- Misses        224      265      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Terdious
Copy link
Contributor Author

Terdious commented May 30, 2024

Hello @Pierre-Gilles,
I wanted to mount a test image but the linux/amd64 version does not work on "Docker magic !", I can't figure out why? Do you have an idea?
No problem with linux/arm64 (v8)

@Terdious Terdious changed the title [WIP] Add charts-history feature and related components and styles [WIP] Add charts-history feature May 31, 2024
@Terdious Terdious closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant