-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add charts-history feature #2091
Conversation
#2594 Bundle Size — 12.07MiB (+19.12%).
Warning Bundle contains 3 duplicate packages – View duplicate packages Warning Bundle introduced 2 new packages: xlsx-js-style, sweetalert2 – View changed packages Bundle metrics
|
Current #2594 |
Baseline #2576 |
|
---|---|---|
Initial JS | 7.38MiB (+35.22% ) |
5.46MiB |
Initial CSS | 305.06KiB (+0.69% ) |
302.96KiB |
Cache Invalidation | 70.6% |
63.14% |
Chunks | 53 (+3.92% ) |
51 |
Assets | 172 (+1.18% ) |
170 |
Modules | 1506 (+1.76% ) |
1480 |
Duplicate Modules | 22 (+4.76% ) |
21 |
Duplicate Code | 0.75% (-8.54% ) |
0.82% |
Packages | 126 (+1.61% ) |
124 |
Duplicate Packages | 3 |
3 |
Bundle size by type 3 changes
3 regressions
Current #2594 |
Baseline #2576 |
|
---|---|---|
JS | 9.17MiB (+26.75% ) |
7.24MiB |
IMG | 2.46MiB |
2.46MiB |
CSS | 321.85KiB (+0.66% ) |
319.75KiB |
Fonts | 93.55KiB |
93.55KiB |
Other | 17.86KiB (+1.91% ) |
17.53KiB |
HTML | 13.58KiB |
13.58KiB |
Bundle analysis report Branch Terdious:add-view-charts Project dashboard
***Add charts-history link to header*** ***Add style for EditBox and EmptyColumnDropZone*** ***Update createDashboard button text*** ***Add EmptyColumnDropZone and BottomDropZone components*** ***Add routes for charts history pages
***Remove unused import*** ***Update dashboard retrieval*** ***Update device features retrieval*** ***Update language files*** ***Update device controller
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2091 +/- ##
==========================================
- Coverage 98.40% 98.12% -0.29%
==========================================
Files 858 860 +2
Lines 14081 14141 +60
==========================================
+ Hits 13857 13876 +19
- Misses 224 265 +41 ☔ View full report in Codecov by Sentry. |
Hello @Pierre-Gilles, |
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!