Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Update .travis.yml to manage docker build #387

Merged
merged 13 commits into from
Oct 12, 2018
Merged

🔧 Update .travis.yml to manage docker build #387

merged 13 commits into from
Oct 12, 2018

Conversation

VonOx
Copy link
Contributor

@VonOx VonOx commented Jul 26, 2018

So i have managed to build docker image with several tag:

  • latest ( on master branch )
  • major version ( on release/tag )

Image is pushed to DockerHub

You need to set env variable in Travis and disable automatic build in docker hub:

  • DOCKER_PASSWORD
  • DOCKER_USERNAME

⚠️ Complete build need to be tested ( with documentation )

Performance: added yarn cache to speed up installation of deps

@VonOx
Copy link
Contributor Author

VonOx commented Jul 26, 2018

Automatic Build need to be disabled in DockerHub

@VonOx VonOx mentioned this pull request Sep 17, 2018
@Pierre-Gilles
Copy link
Contributor

Hey!

Thanks for your PR :)

Why do you have to repeat your steps for all version of Node.js ? It feels hacky, isn't that possible to have only one step with all versions?

Just a little feedback, from what I've seen in the industry, it's more common to have a Docker tag for each major version.

Example:

Because if we switch to Gladys v4 with breaking changes, it will breaks everyone using this. A "stable" doesn't work!

Can you switch to a tag by major version ? (you split the version by "." and take only the first number)

@VonOx
Copy link
Contributor Author

VonOx commented Sep 18, 2018

Why do you have to repeat your steps for all version of Node.js ? It feels hacky, isn't that possible to have only one step with all versions?

Need some experiment.

Can you switch to a tag by major version ? (you split the version by "." and take only the first number)

Yep.

@VonOx
Copy link
Contributor Author

VonOx commented Sep 26, 2018

https://hub.docker.com/r/vonox/gladys/tags/
https://travis-ci.org/VonOx/Gladys-trytravis/jobs/433717903

Tested on release/tag for major V4.

Also added cache: yarn to test stage for performance.

@Pierre-Gilles Pierre-Gilles merged commit bc44349 into GladysAssistant:master Oct 12, 2018
@Pierre-Gilles
Copy link
Contributor

Really great job, it works nice! I love the multi-stage view on Travis :)

👏 👏 👏 👏

@VonOx VonOx deleted the travisci-dockerbuild branch October 12, 2018 06:40
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants