-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Update .travis.yml to manage docker build #387
🔧 Update .travis.yml to manage docker build #387
Conversation
Automatic Build need to be disabled in DockerHub |
Hey! Thanks for your PR :) Why do you have to repeat your steps for all version of Node.js ? It feels hacky, isn't that possible to have only one step with all versions? Just a little feedback, from what I've seen in the industry, it's more common to have a Docker tag for each major version. Example:
Because if we switch to Gladys v4 with breaking changes, it will breaks everyone using this. A "stable" doesn't work! Can you switch to a tag by major version ? (you split the version by "." and take only the first number) |
Need some experiment.
Yep. |
Merge test steps and build documentation in separate step. Tag Docker image with major version ( was stable )
* Now tag by Major version or latest * Merge test suite * Build and deploy in same task
https://hub.docker.com/r/vonox/gladys/tags/ Tested on release/tag for major V4. Also added |
Really great job, it works nice! I love the multi-stage view on Travis :) 👏 👏 👏 👏 |
So i have managed to build docker image with several tag:
Image is pushed to DockerHub
You need to set env variable in Travis and disable automatic build in docker hub:
Performance: added yarn cache to speed up installation of deps