Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth service #505

Merged
merged 5 commits into from
Oct 16, 2020
Merged

Conversation

atrovato
Copy link
Contributor

@atrovato atrovato commented Jul 1, 2019

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If your changes modify the API (REST or Node.js), did you modify the documentation? (Documentation is based on comments in code)

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Bluetooth service to handle Bluetooth devices.

@atrovato
Copy link
Contributor Author

Wait #512 PR to be merged to get device / feature definition updates.

@Pierre-Gilles
Copy link
Contributor

Hello! De retour de congés, je reprend les PR une par une.

A quel niveau es-tu sur celle-ci?

@atrovato
Copy link
Contributor Author

Salut, suite à notre discussion sur MQTT et les sub-services, ce service nécessite de grandes modifications. Du coup, la relecture n'est pas encore nécessaire.

@atrovato
Copy link
Contributor Author

atrovato commented Oct 6, 2019

The service is still in standby, the community is moving on noble library, and some others may appear soon.
I'll try new version as there are available.

@Pierre-Gilles
Copy link
Contributor

Ok!

@Pierre-Gilles Pierre-Gilles changed the title Bluetooth service [WIP] Bluetooth service Feb 27, 2020
@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #505 into master will increase coverage by 0.02%.
The diff coverage is 93.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
+ Coverage   93.50%   93.53%   +0.02%     
==========================================
  Files         428      461      +33     
  Lines        5607     6112     +505     
==========================================
+ Hits         5243     5717     +474     
- Misses        364      395      +31     
Impacted Files Coverage Δ
server/utils/constants.js 100.00% <ø> (ø)
...vices/bluetooth/lib/commands/bluetooth.setValue.js 33.33% <33.33%> (ø)
...ices/bluetooth/lib/device/bluetooth.information.js 75.40% <75.40%> (ø)
...bluetooth/lib/commands/bluetooth.connectDevices.js 87.50% <87.50%> (ø)
...ervices/bluetooth/lib/events/bluetooth.scanStop.js 87.50% <87.50%> (ø)
...th/lib/utils/characteristic/bluetooth.subscribe.js 87.50% <87.50%> (ø)
.../services/bluetooth/lib/commands/bluetooth.scan.js 90.32% <90.32%> (ø)
...ooth/lib/commands/bluetooth.subscribePeripheral.js 90.90% <90.90%> (ø)
...etooth/lib/commands/bluetooth.applyOnPeripheral.js 92.85% <92.85%> (ø)
...etooth/lib/utils/characteristic/bluetooth.write.js 93.33% <93.33%> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc98c16...cd036e6. Read the comment docs.

@Pierre-Gilles
Copy link
Contributor

Back on Bluetooth ? 😍

@atrovato
Copy link
Contributor Author

Just tried with last @abandonware/noble, but not working on windows...
And update branch to fix merge conflicts by the way.

@atrovato atrovato force-pushed the bluetooth-service branch 2 times, most recently from 2f2a8fd to 37b049f Compare September 12, 2020 20:11
@atrovato atrovato force-pushed the bluetooth-service branch 11 times, most recently from cf96978 to bf21d21 Compare September 26, 2020 13:15
@atrovato atrovato force-pushed the bluetooth-service branch 11 times, most recently from 235b4c5 to 526b491 Compare October 6, 2020 19:56
@atrovato atrovato changed the title [WIP] Bluetooth service Bluetooth service Oct 10, 2020
@atrovato atrovato marked this pull request as ready for review October 10, 2020 18:25
@Pierre-Gilles
Copy link
Contributor

Thank you very much for this PR, this is gold 🥇

I just put one small comment.

Do you think it could be merged in master? I tested it on my side, it works fine on the UI/discovery part.

I don't have much devices to tests so I'm not the best user to test this, but if it's stable we can definitely merge it on master so all users can try it before the RC :)

@Pierre-Gilles
Copy link
Contributor

Hey! Thanks for your changes.

Is this ready to merge?

@Pierre-Gilles Pierre-Gilles merged commit 4a673c3 into GladysAssistant:master Oct 16, 2020
@LM1LC3N7
Copy link
Contributor

🥳

@Pierre-Gilles
Copy link
Contributor

Many thanks for your work on this major PR @atrovato ! 🥳

This was the n°1 requests for Gladys 4, and we now have it :)

Can't wait to see more integrations around the bluetooth in Gladys.

R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
* Bluetooth service

* Bluetooth: improve front

* Bluetooth: fix random test conflicted with caldav

* Bluetooth: fix docker script

* Rollback circle changes
@atrovato atrovato deleted the bluetooth-service branch November 28, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants