Improve scene view #649
Merged
Improve scene view #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Gilles
changed the title
13 tasks
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 392 392
Lines 4866 4866
=======================================
Hits 4466 4466
Misses 400 400
Continue to review full report at Codecov.
|
R6n0
pushed a commit
to R6n0/Gladys
that referenced
this pull request
Dec 2, 2020
* Improve scene view by making it vertical * Add trigger UI edition * Improve display of trigger with units * Use react-select in choose trigger card * Translate add trigger card * Migrate triggers to the scene table * Fix device.get filtered by name * Remove trigger table tests * Remove triggers controllers` * Translate chooseActionCard and use react-select * Improve responsive of device state change trigger card * Add action icon in config variable * Display room in device state trigger select * Improve responsive & sort device feature name * Delay action box working * Telegram card in scene view * Add loading state on scene view * Translate and bugfix delay card * Translate & make send message work * Add explanation text and placeholder * Clean actions group if needed * Add an error message in case saving the scene fail * Add all translations * Fix server-side code for lights.turn-on * Fix scenes tests * Remove trigger folder * Handle triggers + add tests * Fix scenes tests * Add listener on EVENTS.ACTION.TRIGGERED * Improve demo mode * Add test on executeSingleAction * Fix links active state * Add send message action + tests * Add more tests to room.get * Improve code coverage on device.get * Add more tests on scene.get
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm teston both front/server)npm run eslinton both front/server)npm run prettieron both front/server)front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!