Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #821 - Switch to correct package eudev to fix usb service #822

Merged
merged 5 commits into from
Jun 8, 2020

Conversation

VonOx
Copy link
Contributor

@VonOx VonOx commented May 29, 2020

@Pierre-Gilles
Copy link
Contributor

Pierre-Gilles commented Jun 1, 2020

Did you test this image ? I don't understand how this will work, because as the package installed are removed by apk del .build-deps just after, will this work? (maybe yes, just asking before merging! :D)

@VonOx
Copy link
Contributor Author

VonOx commented Jun 1, 2020

No no don't merge this, I will request approve when this PR is ready 😉
( forgot WIP in title sorry)

@VonOx VonOx changed the title Fix #821 - Switch to correct package eudev to fix usb service WIP Fix #821 - Switch to correct package eudev to fix usb service Jun 1, 2020
@VonOx
Copy link
Contributor Author

VonOx commented Jun 2, 2020

So finally builded and tested this DockerFile

OZW , server are building fine
And node serial is working with eudev.

This PR can be merged

pastebin build log

@VonOx VonOx changed the title WIP Fix #821 - Switch to correct package eudev to fix usb service Fix #821 - Switch to correct package eudev to fix usb service Jun 2, 2020
@VonOx VonOx requested a review from Pierre-Gilles June 2, 2020 09:03
@VonOx VonOx closed this Jun 3, 2020
@VonOx VonOx reopened this Jun 3, 2020
@VonOx VonOx removed the request for review from Pierre-Gilles June 3, 2020 17:30
@VonOx VonOx changed the title Fix #821 - Switch to correct package eudev to fix usb service WIP Fix #821 - Switch to correct package eudev to fix usb service Jun 3, 2020
@VonOx VonOx changed the title WIP Fix #821 - Switch to correct package eudev to fix usb service Fix #821 - Switch to correct package eudev to fix usb service Jun 4, 2020
@VonOx VonOx requested a review from Pierre-Gilles June 4, 2020 08:26
@Pierre-Gilles
Copy link
Contributor

Du coup c'est quoi la conclusion sur cette PR ? :)

@VonOx
Copy link
Contributor Author

VonOx commented Jun 8, 2020

Que ça fonctionne et que tu peux merge

@Pierre-Gilles Pierre-Gilles merged commit 4a4a992 into GladysAssistant:master Jun 8, 2020
NickDub-old pushed a commit to NickDub/Gladys that referenced this pull request Aug 7, 2020
…service (GladysAssistant#822)

* Switch to correct package eudev to fix usb service

* Adding eudev as sys deps

* remove eudev from build deps

* Update Dockerfile.buildx

Keep DockerFile consistent

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
@VonOx VonOx deleted the fix-docker-usb branch October 21, 2020 14:55
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
…service (GladysAssistant#822)

* Switch to correct package eudev to fix usb service

* Adding eudev as sys deps

* remove eudev from build deps

* Update Dockerfile.buildx

Keep DockerFile consistent

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants