Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change thumbnails size on chapter list #15

Open
Jerrk opened this issue Sep 10, 2019 · 13 comments

Comments

@Jerrk
Copy link

commented Sep 10, 2019

i really like the "show tooltips (thumbnails)" option but the thumbnail is a little too small for my taste, is there a possibility to give us an option to change its size?

thanks

@Glagan

This comment has been minimized.

Copy link
Owner

commented Sep 10, 2019

I am using the only thumbnail MangaDex offer, the next bigger picture is the full cover which is generally big, so it could use a lot of data since hovering a row can be fast, but I will add an option to display the full original image.

@Glagan

This comment has been minimized.

Copy link
Owner

commented Sep 11, 2019

The extension of the file isn't always the same for the cover, but I found an ugly way to still display it (I hope it doesn't do too much useless requests to MangaDex).
It looks like this:
2019-09-11_02-24-50
I also updated the tooltip code to display a spinner while it's loading and there shouldn't be anymore weird position bugs after loading.

I also added another option, Next chapter color which you can see in the GIF, because as I thought it is hard to find the next chapter of a title.

I will probably do more tests and publish the update tomorrow.

Glagan added a commit that referenced this issue Sep 11, 2019
Added Hide Higher chapters option (#14)
Added Show full size cover option (#15)
Updated tooltip logic
Updated default colors

@Glagan Glagan closed this Sep 11, 2019

@Jerrk

This comment has been minimized.

Copy link
Author

commented Sep 12, 2019

The size is perfect now :)

Having a bit of a problem with the position though, it's not a big deal but if you know how to fix it would be appreciated :)

https://i.imgur.com/w23Wpt7.mp4

@Glagan

This comment has been minimized.

Copy link
Owner

commented Sep 12, 2019

Yes I actually saw that after I published a second update to display the tooltips on the right, I am currently trying to fix this.

@Glagan Glagan reopened this Sep 12, 2019

@Glagan

This comment has been minimized.

Copy link
Owner

commented Sep 12, 2019

The tooltip is now moved to the left when you hover on the columns on the right.

2019-09-12_23-22-18

The update should be up soon on Chrome and Firefox is having a maintenance so i'll uploade it as soon as possible.

@Glagan Glagan closed this Sep 12, 2019

@Jerrk

This comment has been minimized.

Copy link
Author

commented Sep 17, 2019

I seem to have a problem where if i hover over anything other than the manga title, the thumbnail will sometimes cover my whole screen

hovering chapter title
https://i.imgur.com/jTQPQFL.jpg

-refreshing page-

hovering manga title
https://i.imgur.com/KAPVgSC.png

This seems to be a problem if there is no margin to the left of the page, i use a portrait monitor and i believe that is my issue here, is that something that can be fixed in the script or should i try to figure out some css to take care of it?

If i run my cursor over a bunch of chapter titles in quick succession it it pretty easy to replicate
https://streamable.com/lqv72

@Glagan

This comment has been minimized.

Copy link
Owner

commented Sep 17, 2019

What browser are you using ?

I think I can see where this error come from, I will try to replicate on my own and I'm sure I can fix it, don't worry about making your own CSS ;)

@Glagan Glagan reopened this Sep 17, 2019

@Jerrk

This comment has been minimized.

Copy link
Author

commented Sep 17, 2019

i'm on firefox nightly ver. 71.0a1

@Glagan

This comment has been minimized.

Copy link
Owner

commented Sep 17, 2019

I think I fixed one problem for now, the fact that you are using portrait mode might cause a bug if you have a very large screen (I am using the width of the screen to set the max width), but I should have fixed it too.
Some tooltips still get stuck for some reasons after you stop hovering a row, I will try to fix that and I will publish an update.

Glagan added a commit that referenced this issue Sep 17, 2019
Fix tooltips (#15)
Tooltips now have a max height
Bigger tooltips when hovering the first columns
Show tooltips over the first column when hovering the second column
Avoid intercepting pointer events on tooltips
Fix tooltips getting stuck when leaving a row
@Glagan

This comment has been minimized.

Copy link
Owner

commented Sep 17, 2019

I published an update that should be already up for Firefox and soon for Chrome.
I'll let this issue open until you tell me everything is working fine.

@Jerrk

This comment has been minimized.

Copy link
Author

commented Sep 18, 2019

https://i.imgur.com/HKagTB2.gifv

They no longer fill up my screen but they're back to the old size which i thought was too small as you can see when i hover the manga title the size is perfect but when i hover the chapter title it is about half the size

@Glagan

This comment has been minimized.

Copy link
Owner

commented Sep 18, 2019

What is your screen resolution ?
If there is less available space on the left the thumbnail will be smaller.
I also set a reasonable width based on the available space to avoid the tooltip to be really tall and being croped to fit on the screen.

@Jerrk

This comment has been minimized.

Copy link
Author

commented Sep 18, 2019

1440x2560
so yeah it is wider than normal
https://i.imgur.com/DzEForB.png
the thumbnail could be about 150 more pixels wide to fit for me
is it possible to setup the tooltip to inherit the manga title column width perhaps? or does it have to be a fixed pixel width?
https://i.imgur.com/3rMIGIl.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.