Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Already read chapter shows as "next chapter" or nothing on follows page #27

Open
Jerrk opened this issue Feb 17, 2020 · 16 comments
Open

Already read chapter shows as "next chapter" or nothing on follows page #27

Jerrk opened this issue Feb 17, 2020 · 16 comments

Comments

@Jerrk
Copy link

@Jerrk Jerrk commented Feb 17, 2020

I'm reading a bunch of my manga on mobile using tachiyomi, this syncs the chapter # to myanimelist which in turn gets picked up by MMD.

In this picture you can see that i've read up to chapter 30 on Tachiyomi -> MAL (accessing the pages from tachiyomi while logged in through web-view ticks the read option even if i never clicked it on desktop)

And it correctly shows as my last read chapter correctly.

However from the https://mangadex.org/follows page, it shows up as the next chapter color.

I have multiple manga with this issue, where i havent touched them on my desktop browser but i have read them on tachiyomi and their chapter # from MAL has been increased.

Heres a different example where i havent caught up yet and the manga page shows correctly the next chapter color.

However the follows list shows nothing at all

If i then read it on tachiyomi and MAL updates the manga page changes correctly as it should.

but the follows page still shows no colour at all.

any ideas of where the problem might lie here and if theres anything that can be done to fix it? 😃

@Glagan

This comment has been minimized.

Copy link
Owner

@Glagan Glagan commented Feb 17, 2020

Hum, weird, can I have all the colors you set in the options, I never saw this problem.
I'm also looking at the code and I don't see exactly what would cause that since it's not even a edge case or something else.

@Jerrk

This comment has been minimized.

Copy link
Author

@Jerrk Jerrk commented Feb 18, 2020

heres my settings export
{"options":{"lastReadColor":"rgba(75, 180, 60, 0.6)","lowerChaptersColor":"rgba(180, 102, 75, 0.4)","lastOpenColors":["transparent"],"openedChaptersColor":"rgba(102, 75, 180, 0.3)","hideLowerChapters":true,"saveOnlyHigher":true,"saveOnlyNext":true,"confirmChapter":false,"saveAllOpened":true,"maxChapterSaved":299,"updateHistoryPage":true,"updateOnlyInList":false,"historySize":100,"updateMDList":true,"showTooltips":true,"highlightChapters":true,"showNotifications":false,"showErrors":true,"onlineSave":false,"onlineURL":"https://mmd.nikurasu.org/api/","username":"","isLoggedIn":false,"token":"","version":2.3,"subVersion":16,"higherChaptersColor":"transparent","nextChapterColor":"#ffc125","hideHigherChapters":false,"showFullCover":true,"coverMaxHeight":100,"hideLastRead":false}}

@Glagan

This comment has been minimized.

Copy link
Owner

@Glagan Glagan commented Feb 18, 2020

If you don't see the chapter in green in your chapter list (on the follow page) it's because the Last read color doesn't apply, only the list of Last open colors will apply in order.

But I see the problem, when the last chapter is updated from MyAnimeList it isn't updated in the local storage for some reasons, if it did you would see other colors in the title page.
The first title you screenshot is still at 29 and the second one is at 35 (the first time you saved it)
I'm going to look at it and I'll update.

@Glagan Glagan closed this in de9817f Feb 18, 2020
@Glagan

This comment has been minimized.

Copy link
Owner

@Glagan Glagan commented Feb 18, 2020

This should be fixed, if it's still there with version 2.3.17 you can re-open this issue.

@Jerrk

This comment has been minimized.

Copy link
Author

@Jerrk Jerrk commented Feb 18, 2020

i'm on 2.3.17 and it doesn't look like its changed anything 😢

https://i.imgur.com/RLWMROD.gif

this is an example of a working manga for whatever reason

this one doesnt work

Sometimes it even changes color on items that aren't even on MAL...


@Jerrk

This comment has been minimized.

Copy link
Author

@Jerrk Jerrk commented Feb 18, 2020

Hmmm it seems to be inconsistent where sometimes it works and it sometimes doesnt, ill test it some more.

@Glagan

This comment has been minimized.

Copy link
Owner

@Glagan Glagan commented Feb 18, 2020

I saw one title without MyAnimeList in your gif, if there is none there is no way for MyMangaDex to sync.
For the purple color of the last image, it's a chapter you opened, if there is no MAL progress is still tracked (as long as you read with MyMangaDex), and if you have the Save all opened options it will highlight all chapters you opened, you can disable it or set it's color to transparent.

This bug is really weird, I tried myself with the same title (Aharen) yesterday and it worked, I am also trying right now and it also works, could I have your new save file for this version ?

@Glagan Glagan reopened this Feb 18, 2020
@Jerrk

This comment has been minimized.

Copy link
Author

@Jerrk Jerrk commented Feb 18, 2020

MAL seems to currently be down for maintenance as well, that might be contributing to the problems.

here are my current settings

"options":{"lastReadColor":"rgba(75, 180, 60, 0.6)","lowerChaptersColor":"rgba(180, 102, 75, 0.4)","lastOpenColors":["rgba(0, 0, 122, 0.8)","rgba(0, 0, 122, 0.6)"],"openedChaptersColor":"rgba(102, 75, 180, 0.3)","hideLowerChapters":true,"saveOnlyHigher":true,"saveOnlyNext":true,"confirmChapter":false,"saveAllOpened":true,"maxChapterSaved":299,"updateHistoryPage":true,"updateOnlyInList":false,"historySize":100,"updateMDList":true,"showTooltips":true,"highlightChapters":true,"showNotifications":false,"showErrors":true,"onlineSave":false,"onlineURL":"https://mmd.nikurasu.org/api/","username":"","isLoggedIn":false,"token":"","version":2.3,"subVersion":17,"higherChaptersColor":"transparent","nextChapterColor":"rgba(139, 101, 8, 0.5)","hideHigherChapters":false,"showFullCover":true,"coverMaxHeight":100,"hideLastRead":false}}

I tested again reading on tachiyomi and then refreshing the follows page and that didn't do anything. I had to open the manga chapter list for it to change its color. let me see if i can get you an example real quick

@Jerrk

This comment has been minimized.

Copy link
Author

@Jerrk Jerrk commented Feb 18, 2020

Here you can see that the listing is not highlighted on the follows page, i then open the manga page and then refresh the follows page and now it changes color. at no point do i open a chapter in my browser

https://i.imgur.com/tZPm5Xz.gifv

@Glagan

This comment has been minimized.

Copy link
Owner

@Glagan Glagan commented Feb 18, 2020

It's normal, if the manga has been updated on MAL only, I need to get your data to update local storage, and I only get your MAL data in the title page and when you read, to avoid sending a lot of requests to MAL (there could be 100 requests for each page if I asked MAL everywhere).

@Jerrk

This comment has been minimized.

Copy link
Author

@Jerrk Jerrk commented Feb 18, 2020

So for titles not being on MAL, thus only updating from my specific browser activity with MMD active - is not fixable unless MAL adds the titles to their database - gotcha.


And follows page not updating since i need to access the manga chapter list from my browser to send an API request to MAL - Could there maybe be a soft cap set to only call for X amount of API calls in a given timeframe? would that fix the problem?

Maybe just call for the most recent X amount of manga (i.e the top of the page) so maybe a max of 10 API calls will be made on follows page refresh, could something like that work?

maybe even have a check so that it only does an API call if the manga does NOT have a "next chapter" which would indicate you are already caught up and would make the API request useless.


i'm trying to test some more but with MAL being off and on it's very inconsistent right now.

Another issue i've noticed while doing this is chapter labeled as 25.1, 6.5, 7.2, etc are very incosistently counted as its base chapter. MAL can have upto chapter 25 tracked but if a new chapter with 25.1 gets added and then read, it still shows as "next chapter" since the MAL number didn't increase

@Glagan

This comment has been minimized.

Copy link
Owner

@Glagan Glagan commented Feb 18, 2020

I already save "sub" chapters, if you read them my MyMangaDex, again.
Since MAL only save rounded chapters, if you read them without MyMangaDex and then update your local storage with data from MAL, I just can't know if you have read it or not...

I don't know about adding calls to MAL from the follow page, you never really know what to update and with which delay, if I only update let's say 10% max of all titles in the follow page, maybe all of these titles didn't need to be updated and all others needed to be updated.
This will also slow down highlighting and hiding everything, by slow I mean seconds instead of ms, since MAL itself is really slow.
Also, MAL doesn't have an API, I just make calls to pages and parse them to find what I need, and one part of the calls being slow is that these pages are big (compared to an API call).

@Jerrk

This comment has been minimized.

Copy link
Author

@Jerrk Jerrk commented Feb 19, 2020

I did open the "sub" chapter in my browser with MMD active, it shows as read on the manga page but NOT on the follows page. see pictures above and here is another example

MMD would only need to call for MAL if a manga has a "next chapter" to check if that chapter has been read. The rest of the manga would not have a "next chapter" and that would not constitute a need to call for MAL (MMD already knows you are caught up so no need to waste MAL bandwidth right?).
It's still possible you havent read anything for several weeks and your follow page would be filled with 100 manga with a "next chapter" unread, this is why you could put a limit to say for instance "only call MAL for the most recent X amount of manga"

For me right now, the suggested solution would call for 7 MAL pages (5 if the "sub" chapter thingy gets fixed).
For me personally, giving the page a couple of seconds to load wouldn't be a big deal for me. I have another add-on that auto updates the tab every 30 minutes and showing which manga have tracked off platform would really improve my experience.

All this could also of course be optional

I did a couple more changes so heres my settings export again.
"options":{"lastReadColor":"rgba(75, 180, 60, 0.6)","lowerChaptersColor":"rgba(180, 102, 75, 0.4)","lastOpenColors":["rgba(0, 0, 122, 0.8)","rgba(0, 0, 122, 0.6)"],"openedChaptersColor":"rgba(102, 75, 180, 0.3)","hideLowerChapters":true,"saveOnlyHigher":true,"saveOnlyNext":true,"confirmChapter":false,"saveAllOpened":true,"maxChapterSaved":299,"updateHistoryPage":true,"updateOnlyInList":false,"historySize":100,"updateMDList":true,"showTooltips":true,"highlightChapters":true,"showNotifications":false,"showErrors":true,"onlineSave":false,"onlineURL":"https://mmd.nikurasu.org/api/","username":"","isLoggedIn":false,"token":"","version":2.3,"subVersion":17,"higherChaptersColor":"rgba(139, 101, 8, 0.2)","nextChapterColor":"rgba(139, 101, 8, 0.5)","hideHigherChapters":false,"showFullCover":true,"coverMaxHeight":100,"hideLastRead":false}}

@Jerrk

This comment has been minimized.

Copy link
Author

@Jerrk Jerrk commented Feb 19, 2020

I found another edge case as well, you can't actually read this manga on mangadex, but it shows tracking from MAL and shows upto the chapter read on the chapter page, but does NOT show up on the follows page.

it also seems to redirect to 2 different urls if that matters at all
https://mangadex.org/title/35705/spy-family (from follows page)
https://mangadex.org/title/35705/spyfamily (redirects after looking at the last chapter)



Edit: Another one where all the chapters are unavailible, still shows progress in the chapter list but NOT on the follows list.


@Glagan

This comment has been minimized.

Copy link
Owner

@Glagan Glagan commented Feb 20, 2020

I just don't see what it would do that... the links doesn't matter, and unavailable chapters doesn't change anything if your save is updated with MAL.
Can you tell me the exact step you make to reproduce this ? It's working fine for me, and if I update MAL then go to a title page, and then on the follow page everything is being highlighted as expected.
Again, you need to go to a title page before going back to the follow page since nothing is saved or done in the follow page right now.
Your idea for MAL refresh doesn't seems to bad, I might do it and put it behind an option for those who doesn't need that.

If you have the saveOnlyNext option enabled and confirmChapter option disabled, MyMangaDex might not actually save the sub chapter since it's technically not an higher chapter (for MAL).

Also, I'm sorry but I don't see what you mean with the last 2 screenshots ? You're at chapter 18 and you show chapter 29 and 30 in the follow page, it won't highlight them.

@Jerrk

This comment has been minimized.

Copy link
Author

@Jerrk Jerrk commented Feb 20, 2020

i disabled saveonlynext and enabled confirmchapter i then opened the sub-chapter and confirmed the update. now it DOES show on my follows list as well as on the chapter list.
Any idea why the chapter list showed them as read before but only now the follows list would do the same?

I have been going back and forth between chapters on the title page and the follows page but spyxfamily will not change color on the follows page whatever i do. i removed from reading list completely, then added it back, nothing. i opened each and every single chapter and went through them all and confirming the MAL updates. i removed it completely from MAL and then i re-read the latest chapter.
it just won't change color on the follows page for some reason...
Maybe some weird character type throwing up an error? the x is atypical x=/=×

Yeah sorry i was not at all clear, "LV999 No Murabito" doesnt show any color at all even though i have started reading it and am on chapter 17. right below you can see "Sekai ka Kanojo ka Erabenai" which i also have started reading and am on chapter 21.
"LV999 No Murabito" does not show color on the chapters as "higher chapters" while "Sekai ka Kanojo ka Erabenai" does.

I'll keep hoping for that MAL option 😁

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.