-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
applet.selftest: fixes for revC0 and later #278
Closed
TomKeddie
wants to merge
3
commits into
GlasgowEmbedded:master
from
TomKeddie:tomk_20210225_self_test
Closed
applet.selftest: fixes for revC0 and later #278
TomKeddie
wants to merge
3
commits into
GlasgowEmbedded:master
from
TomKeddie:tomk_20210225_self_test
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That doesn't actually fix the false positives. |
Agreed, I'll read the pr more closely. |
@whitequark I'm not sure exactly what more we can do here without more control over the ice40 pullups (do we have this now?). pins-pull already does a walking ones test of the pullups.
|
Measure capacitance by observing decay time. You are not required to implement this. |
Ok, thanks - I'll just close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#151