Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applet.program_ice40: remove manual chunked writes #87

Closed

Conversation

kbeckmann
Copy link
Contributor

The previous code didn't build anymore. This was because we tried to
write [0] which isn't supported anymore because of the memoryview()
usage. Perhaps that should be fixed instead?

support.chunked_fifo implements the chunked writes instead now.

The previous code didn't build anymore. This was because we tried to
write [0] which isn't supported anymore because of the memoryview()
usage. Perhaps that should be fixed instead?

support.chunked_fifo implements the chunked writes instead now.
@whitequark
Copy link
Member

This of course doesn't work since gateware performs dechunking in program_ice40. Have you tested it on real hardware?

@kbeckmann
Copy link
Contributor Author

Ouch. Good point, no I just checked with a logic analyser. I'll change the commit to just remove the [0] stuff. Or what should we do about that? Fix it in the chunked_fifo?

@whitequark
Copy link
Member

Ideally this should inherit from spi-master.

@whitequark
Copy link
Member

But the bug you found should also be fixed; fifo.write([0]) is supposed to work. It's in DirectAccessMultiplexer.

@kbeckmann
Copy link
Contributor Author

Alright, then I'll close this. Sorry for the noise.

@kbeckmann kbeckmann closed this Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants