New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Unibeautify as core #1174

Open
Glavin001 opened this Issue Sep 4, 2016 · 10 comments

Comments

@Glavin001
Owner

Glavin001 commented Sep 4, 2016

See https://github.com/Unibeautify/unibeautify

Features:

  • Completely rewritten in TypeScript which is then compiled to JavaScript
    • Faster and cleaner implementation, taking into consideration all that we have learned from Atom-Beautify.
    • Will be easier to contribute to with TypeScript aiding our development and ensuring there are less mistakes in the code
  • #620 - Separate Beautifiers from Atom-Beautify / Unibeautify
    • Users will install only the beautifiers they need. This will heavily reduce installation time and installation folder size of Atom-Beautify.
  • #457 - Multiple active beautifiers
  • #1041 - Dynamic beautifier(s) per project
  • More powerful third-party options importing support with https://github.com/Unibeautify/unibeautify-options-importer

@Glavin001 Glavin001 added this to the v1.0.0 milestone Sep 4, 2016

@Glavin001 Glavin001 self-assigned this Sep 4, 2016

Glavin001 added a commit that referenced this issue Sep 26, 2016

Glavin001 added a commit that referenced this issue Sep 26, 2016

Glavin001 added a commit that referenced this issue Sep 26, 2016

Glavin001 added a commit that referenced this issue Sep 26, 2016

@Glavin001 Glavin001 referenced this issue Jun 19, 2017

Closed

It takes alot of time to update\reinstall #1675

4 of 4 tasks complete

@Glavin001 Glavin001 removed the in-progress label Jun 20, 2017

@MattRiddell

This comment has been minimized.

Show comment
Hide comment
@MattRiddell

MattRiddell Jun 20, 2017

This one on the back burner?

This one on the back burner?

@Glavin001

This comment has been minimized.

Show comment
Hide comment
@Glavin001

Glavin001 Jun 20, 2017

Owner

Yeah, I only have so much time so I'm spending it updating the Atom-Beautify code. Once things on Atom-Beautify are going well I will port over the new features to Unibeautify and polish up. 😃

Owner

Glavin001 commented Jun 20, 2017

Yeah, I only have so much time so I'm spending it updating the Atom-Beautify code. Once things on Atom-Beautify are going well I will port over the new features to Unibeautify and polish up. 😃

@Glavin001

This comment has been minimized.

Show comment
Hide comment
@Glavin001

Glavin001 Feb 6, 2018

Owner

Update: While I am working on the Unibeautify core, @szeck87 has been making great strides in upgrading Atom-Beautify to using Unibeautify.

Owner

Glavin001 commented Feb 6, 2018

Update: While I am working on the Unibeautify core, @szeck87 has been making great strides in upgrading Atom-Beautify to using Unibeautify.

@kLOsk

This comment has been minimized.

Show comment
Hide comment
@kLOsk

kLOsk Jun 10, 2018

Any chance this is still happening? :-/

kLOsk commented Jun 10, 2018

Any chance this is still happening? :-/

@Glavin001

This comment has been minimized.

Show comment
Hide comment
@Glavin001

Glavin001 Jun 10, 2018

Owner

@kLOsk Thank you for your interest!

Migrating to Unibeautify is still happening -- although quality takes time -- and @szeck87 has made a lot of progress on the Unibeautify branch for Atom-Beautify 🎉 . And we've both been working hard to build a strong foundation for Unibeautify itself: https://unibeautify.com/

Feedback is very appreciated! Thanks in advance!

Help improve Atom-Beautify by completing the quick questionnaire: https://goo.gl/iEHBNr

Sign up for Unibeautify CI: https://goo.gl/jmM4QN

Owner

Glavin001 commented Jun 10, 2018

@kLOsk Thank you for your interest!

Migrating to Unibeautify is still happening -- although quality takes time -- and @szeck87 has made a lot of progress on the Unibeautify branch for Atom-Beautify 🎉 . And we've both been working hard to build a strong foundation for Unibeautify itself: https://unibeautify.com/

Feedback is very appreciated! Thanks in advance!

Help improve Atom-Beautify by completing the quick questionnaire: https://goo.gl/iEHBNr

Sign up for Unibeautify CI: https://goo.gl/jmM4QN

@kLOsk

This comment has been minimized.

Show comment
Hide comment
@kLOsk

kLOsk Jun 10, 2018

Thanks @Glavin001, is it advised / possible to run the current dev branch as an Atom package?

kLOsk commented Jun 10, 2018

Thanks @Glavin001, is it advised / possible to run the current dev branch as an Atom package?

@szeck87

This comment has been minimized.

Show comment
Hide comment
@szeck87

szeck87 Jun 11, 2018

Collaborator

@kLOsk you can clone the repository locally and checkout the unibeautify branch. Then apm link it from the terminal/command prompt. What is there now is pretty out of date though, let me open a PR to merge what I have up to it.

Collaborator

szeck87 commented Jun 11, 2018

@kLOsk you can clone the repository locally and checkout the unibeautify branch. Then apm link it from the terminal/command prompt. What is there now is pretty out of date though, let me open a PR to merge what I have up to it.

@michaelprescott

This comment has been minimized.

Show comment
Hide comment
@michaelprescott

michaelprescott Jun 17, 2018

FYI, the poll on the atom-beautify page looks like a clickable image of poll results. Visitors that roll over it may expect to click on the image to be taken to the actual poll widget to also give their feedback; however, it's actually an inline widget where each bar is clickable (there are only a few pixels between each item so you can only tell if you roll over the container very slowly). It's a subtle UI issue, but enough that someone may not realize that clicking anywhere will immediately casts a vote for a feature. As a result, I imagine the top item is getting very skewed, a cloud based code formatting service. Please, no.

FYI, the poll on the atom-beautify page looks like a clickable image of poll results. Visitors that roll over it may expect to click on the image to be taken to the actual poll widget to also give their feedback; however, it's actually an inline widget where each bar is clickable (there are only a few pixels between each item so you can only tell if you roll over the container very slowly). It's a subtle UI issue, but enough that someone may not realize that clicking anywhere will immediately casts a vote for a feature. As a result, I imagine the top item is getting very skewed, a cloud based code formatting service. Please, no.

@jack1142

This comment has been minimized.

Show comment
Hide comment
@jack1142

jack1142 Jun 17, 2018

I didn't even know it's clickable and thought they are poll results :o

I didn't even know it's clickable and thought they are poll results :o

@Glavin001

This comment has been minimized.

Show comment
Hide comment
@Glavin001

Glavin001 Jun 18, 2018

Owner

Thanks for the feedback, @michaelprescott @jack1142 . I think https://github.com/apex/gh-polls would be the appropriate place for comments on the poll UI itself.

On our end, a message could be added to the README to make it clear the numbers shown are in fact the only poll results view and clicking the bars will cast a vote for the respective option. I would be happy to merge a PR making sure a change 😃 . Thanks in advance!

Owner

Glavin001 commented Jun 18, 2018

Thanks for the feedback, @michaelprescott @jack1142 . I think https://github.com/apex/gh-polls would be the appropriate place for comments on the poll UI itself.

On our end, a message could be added to the README to make it clear the numbers shown are in fact the only poll results view and clicking the bars will cast a vote for the respective option. I would be happy to merge a PR making sure a change 😃 . Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment