Respect the new `core.telemetryConsent` configuration option #1179

Closed
lee-dohm opened this Issue Sep 5, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@lee-dohm

lee-dohm commented Sep 5, 2016

Description

In Atom v1.11.0-beta0 a new Telemetry Consent system was introduced. The user's decision is stored at core.telemetryConsent. The three possible values are undecided, no and limited. The intent is that consent is given if and only if limited is chosen. The atom-beautify package should respect this decision also.

Expected Results

When core.telemetryConsent is set to undecided or no, atom-beautify does not collect any data on the user's behavior or use of the package.

Checklist

  • N/A - I have tried uninstalling and reinstalling Atom Beautify to ensure it installed properly
  • N/A - I have reloaded (or restarted) Atom to ensure it is not a caching issue
  • Searched for existing Atom Beautify Issues at https://github.com/Glavin001/atom-beautify/issues
    so I know this is not a duplicate issue
  • N/A - Generated debugging information and added link for debug.md Gist to this issue

@lee-dohm lee-dohm referenced this issue in atom/atom Sep 5, 2016

Merged

Add telemetry consent setting #12281

@Glavin001

This comment has been minimized.

Show comment
Hide comment
@Glavin001

Glavin001 Sep 6, 2016

Owner

Glad to see this built-in to Atom! If someone does not submit a Pull Request by this upcoming weekend, I'll implement it and publish a release. Thanks for letting me know!

Owner

Glavin001 commented Sep 6, 2016

Glad to see this built-in to Atom! If someone does not submit a Pull Request by this upcoming weekend, I'll implement it and publish a release. Thanks for letting me know!

@Glavin001 Glavin001 self-assigned this Sep 6, 2016

@Glavin001 Glavin001 added this to the v0.30.0 milestone Sep 6, 2016

@Glavin001 Glavin001 referenced this issue Sep 6, 2016

Closed

Google Analytics #47

1 of 1 task complete

@Glavin001 Glavin001 removed their assignment Jan 14, 2017

@Glavin001 Glavin001 removed the in-progress label Jan 14, 2017

@Glavin001 Glavin001 self-assigned this Apr 20, 2017

@Glavin001 Glavin001 closed this in 45a9345 Apr 20, 2017

@Glavin001

This comment has been minimized.

Show comment
Hide comment
@Glavin001

Glavin001 Apr 20, 2017

Owner

Published to v0.29.23

Owner

Glavin001 commented Apr 20, 2017

Published to v0.29.23

@Glavin001

This comment has been minimized.

Show comment
Hide comment
Owner

Glavin001 commented Apr 20, 2017

image

image

Glavin001 added a commit that referenced this issue Apr 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment