Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Display object size in bytes on the session tab, along with total #100

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

jasonrclark commented Jul 28, 2011

This addition adds a Size (bytes) column to the Session tab that will show the binary serialized size of each object in session. It also adds a calculated total the bottom of the tab.

Owner

avanderhoorn commented Jul 29, 2011

Just a thought. What do you think the perf overhead of this is? I know we will only be running it on requests that have glimpse enabled, but I'm just wondering.

Contributor

jasonrclark commented Jul 29, 2011

I know that we've been using this technique at my current company for some time (and with reason, as we've worked to whittle down session sizes), and we haven't seen any particular drag from it.

I can get some timings together to look at it more concretely first thing next week if you'd like.

Contributor

jasonrclark commented Aug 1, 2011

I did some basic timings with the binary serialization. These tests serialized a mixed group of objects containing strings, ints, guids, and a more complex serializable class with several public properties.

For a session containing 140400 bytes, it averaged right around 3ms of overhead for doing the serialization to sum up the byte count. Given that this is already a pretty large session, that seems pretty lightweight.

Bumping the objects up by a factor of ten (almost 1.5 MB worth of objects) yielded about 38ms. On first blush, it appears to be a pretty linear progression.

Let me know if you'd like to see the timing code I used, or if there are other types of session contents I should look at the behavior of.

Owner

nikmd23 commented Jan 17, 2013

Hey @jasonrclark,

I know it's been a very long time - but we are now in a place where we can start to think about accepting this pull request.

Would you mind updating the code so that it works with the new session tab?

Contributor

jasonrclark commented Feb 12, 2013

Hey Nik,
Glad to hear back from you, even after a long time.

Turns out that I've since changed jobs, and I'm working almost exclusively
in Ruby these days. Not sure I even still have VS installed anywhere, which
kind of limits my chances of making the updates.

Sorry about that!

~Jason

On Thu, Jan 17, 2013 at 7:25 AM, Nik Molnar notifications@github.comwrote:

Hey @jasonrclark https://github.com/jasonrclark,

I know it's been a very long time - but we are now in a place where we can
start to think about accepting this pull request.

Would you mind updating the code so that it works with the new session tabhttps://github.com/Glimpse/Glimpse/blob/System.Web.Abstraction/source/Glimpse.AspNet/Tab/Session.cs
?


Reply to this email directly or view it on GitHubhttps://github.com/Glimpse/Glimpse/pull/100#issuecomment-12372380.

Owner

nikmd23 commented Feb 12, 2013

Hey @jasonrclark,

No worries man - it's our bad for taking so long to get back to you!

Hope you are enjoying your new(ish) job and Ruby. If you are ever interested in trying to get Glimpse running on Rack/Rails we'd love to chat with you. 😉.

Don't worry about this pull request. We'll take a look at updating it ourselves. I mostly want to see what the performance overhead of this will be before we pull it in.

Owner

nikmd23 commented Sep 9, 2013

This is a great idea but we are worried about the performance implications. Maybe we'll revisit this one day, but I'm closing for now.

@nikmd23 nikmd23 closed this Sep 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment