Fix for Issue #146 per my discussion with avanderhoorn #150

Closed
wants to merge 2 commits into
from

Projects

None yet

4 participants

@rroman81

Ironically, I was not able to immediately reproduce a scenario where multiple instances of the IAuthorizationFilter are returned in the sample project. However, I was able to test the change against my original project and it started working.
PS: this is my first pull request. I'd welcome any guidance if I messed something up, like i.e. is the merge operation from my local fixes branch need to propagate all the way to my forked repo?

@rroman81
Owner

Fixed a bug where MVC returns multiple instances of the same Attribute class type during Filter Interception.

Thanks a lot for this commit. We haven't pulled this in yet as we have a new branch that we are doing work on v1 on. I have just switched the default branch of the repository to this so people see this by default now. Any chance that you could do this commit against that dev branch (as we would like you to get the cred for the commit)?

@avanderhoorn
Member

@rroman81 huge thanks for the pull request. Will take a look at it over the next couple of days and try pulling it in.

@Glimpse
Contributor
Glimpse commented May 18, 2012

Thanks a lot for this commit. We haven't pulled this in yet as we have a new branch that we are doing work on v1 on. I have just switched the default branch of the repository to this so people see this by default now. Any chance that you could do this commit against that dev branch (as we would like you to get the cred for the commit)? If you can, only thing to keep in mind is to make the change in core2.

@nikmd23
Member
nikmd23 commented Jan 16, 2013

Glimpse RC1 handles filter in a much better, less hacky way.

As such, the issue reported here is no longer a problem.

I'm closing this issue, please re-open it if you experience with RC1

@nikmd23 nikmd23 closed this Jan 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment