Small refactorings #298

Merged
merged 2 commits into from Apr 22, 2013

Conversation

Projects
None yet
3 participants
@dominiqueplante
Contributor

dominiqueplante commented Mar 30, 2013

No description provided.

@nikmd23

This comment has been minimized.

Show comment
Hide comment
@nikmd23

nikmd23 Apr 5, 2013

Member

Thanks so much for the pull request @dominiqueplante!

I have a few things I hope you can do for us to accept this:

  • Follow the StyleCop rules we have in the Glimpse.Core project. It looks like only the use of { and } is being disobeyed right now. Just look at the warnings generated against GlimpseRuntime.
  • Please sign and return our contributors license agreement.

Also, as I mentioned on Twitter, we really appreciate your wiki contributions as well!

Member

nikmd23 commented Apr 5, 2013

Thanks so much for the pull request @dominiqueplante!

I have a few things I hope you can do for us to accept this:

  • Follow the StyleCop rules we have in the Glimpse.Core project. It looks like only the use of { and } is being disobeyed right now. Just look at the warnings generated against GlimpseRuntime.
  • Please sign and return our contributors license agreement.

Also, as I mentioned on Twitter, we really appreciate your wiki contributions as well!

@dominiqueplante

This comment has been minimized.

Show comment
Hide comment
@dominiqueplante

dominiqueplante Apr 5, 2013

Contributor

Will do :)

On Fri, Apr 5, 2013 at 8:00 AM, Nik Molnar notifications@github.com wrote:

Thanks so much for the pull request @dominiqueplantehttps://github.com/dominiqueplante
!

I have a few things I hope you can do for us to accept this:

  • Follow the StyleCop rules we have in the Glimpse.Core project. It
    looks like only the use of { and } is being disobeyed right now. Just
    look at the warnings generated against GlimpseRuntime.
  • Please sign and return our contributors license agreementhttps://www.dropbox.com/s/4eix4or9ezohi4a/Glimpse%20Project%20Individual%20Contributor%20License%20Agreement.rtf
    .

Also, as I mentioned on Twitterhttp://www.twitter.com/nikmd23/status/320175421331222529,
we really appreciate your wiki contributions as well!


Reply to this email directly or view it on GitHubhttps://github.com/Glimpse/Glimpse/pull/298#issuecomment-15960572
.

Contributor

dominiqueplante commented Apr 5, 2013

Will do :)

On Fri, Apr 5, 2013 at 8:00 AM, Nik Molnar notifications@github.com wrote:

Thanks so much for the pull request @dominiqueplantehttps://github.com/dominiqueplante
!

I have a few things I hope you can do for us to accept this:

  • Follow the StyleCop rules we have in the Glimpse.Core project. It
    looks like only the use of { and } is being disobeyed right now. Just
    look at the warnings generated against GlimpseRuntime.
  • Please sign and return our contributors license agreementhttps://www.dropbox.com/s/4eix4or9ezohi4a/Glimpse%20Project%20Individual%20Contributor%20License%20Agreement.rtf
    .

Also, as I mentioned on Twitterhttp://www.twitter.com/nikmd23/status/320175421331222529,
we really appreciate your wiki contributions as well!


Reply to this email directly or view it on GitHubhttps://github.com/Glimpse/Glimpse/pull/298#issuecomment-15960572
.

avanderhoorn added a commit that referenced this pull request Apr 22, 2013

Merge pull request #298 from dominiqueplante/System.Web.Abstraction
Huge thanks mate... let us know if you are interested in doing more!

@avanderhoorn avanderhoorn merged commit 550408e into Glimpse:System.Web.Abstraction Apr 22, 2013

1 check passed

default TeamCity Build Glimpse :: Continuous Integration finished: Tests passed: 940, ignored: 9
Details
@dominiqueplante

This comment has been minimized.

Show comment
Hide comment
@dominiqueplante

dominiqueplante Apr 25, 2013

Contributor

Thanks!!!

Contributor

dominiqueplante commented Apr 25, 2013

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment