Fix #319 - Allow FileResource to be used outside of Glimpse.Core #320

Merged
merged 1 commit into from Apr 17, 2013

Conversation

Projects
None yet
3 participants
@rho24
Contributor

rho24 commented Apr 16, 2013

Use GetType().Assembly in FileResource to get assembly of subtype.

@rho24

This comment has been minimized.

Show comment
Hide comment
@rho24

rho24 Apr 16, 2013

Contributor

Tested it works locally with Glimpse.NLog for an extra bit of confidence.

Contributor

rho24 commented Apr 16, 2013

Tested it works locally with Glimpse.NLog for an extra bit of confidence.

@nikmd23

This comment has been minimized.

Show comment
Hide comment
@nikmd23

nikmd23 Apr 17, 2013

Member

Love this pull request! Thanks for the tests and everything.

Member

nikmd23 commented Apr 17, 2013

Love this pull request! Thanks for the tests and everything.

nikmd23 added a commit that referenced this pull request Apr 17, 2013

Merge pull request #320 from rho24/issue319
Fix #319 - Allow FileResource to be used outside of Glimpse.Core

@nikmd23 nikmd23 merged commit d1ba28c into Glimpse:master Apr 17, 2013

1 check passed

default TeamCity Build Glimpse :: Continuous Integration finished: Tests passed: 941, ignored: 10
Details

@rho24 rho24 deleted the rho24:issue319 branch Apr 17, 2013

@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Apr 18, 2013

Member

As Nik said, love you work and thanks a lot!

Member

avanderhoorn commented Apr 18, 2013

As Nik said, love you work and thanks a lot!

@rho24

This comment has been minimized.

Show comment
Hide comment
@rho24

rho24 Apr 18, 2013

Contributor

Pleasure working with you as always:)

Contributor

rho24 commented Apr 18, 2013

Pleasure working with you as always:)

@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn May 4, 2013

Member

This is going live with Glimpse.Core 1.3.1.

@rho24 When you next release Glimpse.NLog you will probably need to setup the package to use >= 1.3.1.

Member

avanderhoorn commented May 4, 2013

This is going live with Glimpse.Core 1.3.1.

@rho24 When you next release Glimpse.NLog you will probably need to setup the package to use >= 1.3.1.

@rho24

This comment has been minimized.

Show comment
Hide comment
@rho24

rho24 May 9, 2013

Contributor

Cheers Guys:)

Contributor

rho24 commented May 9, 2013

Cheers Guys:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment