Fix for issue #395 Allowing direct loading of Ajax request from HUD #424

Merged
merged 2 commits into from Jul 1, 2013

Conversation

Projects
None yet
2 participants
@CGijbels
Collaborator

CGijbels commented Jun 28, 2013

This pull request allows the user to load the corresponding Ajax Request into the dashboard, directly from within the HUD Ajax summary view. It is however only possible for Ajax requests related to the application being monitored by Glimpse (so Ajax requests going to Facebook for instance will not be loadable)

@CGijbels

This comment has been minimized.

Show comment
Hide comment
@CGijbels

CGijbels Jun 28, 2013

Owner

to make sure the hyperlink is still shown in the corresponding color depending on whether the css class glimpse-hud-error, glimpse-hud-quite or neither of them has been set

to make sure the hyperlink is still shown in the corresponding color depending on whether the css class glimpse-hud-error, glimpse-hud-quite or neither of them has been set

@CGijbels

This comment has been minimized.

Show comment
Hide comment
@CGijbels

CGijbels Jun 28, 2013

Owner

since the color isn't indicating that you can click on the Ajax request, adding an underline on hover might give enough information to the user as whether it is clickable or not.

since the color isn't indicating that you can click on the Ajax request, adding an underline on hover might give enough information to the user as whether it is clickable or not.

@CGijbels

This comment has been minimized.

Show comment
Hide comment
@CGijbels

CGijbels Jun 28, 2013

Owner

Not all Ajax requests are part of the application being monitored by Glimpse (Facebook Ajax calls for instance), and those have no valid requestId, so no link will be provided in those cases

Not all Ajax requests are part of the application being monitored by Glimpse (Facebook Ajax calls for instance), and those have no valid requestId, so no link will be provided in those cases

@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Jul 1, 2013

Member

Checked the code out locally and looking great. One finial request, can you add an underline for the hyperlink? That way its super obvious that its clickable.

GREAT work mate!!!

Member

avanderhoorn commented Jul 1, 2013

Checked the code out locally and looking great. One finial request, can you add an underline for the hyperlink? That way its super obvious that its clickable.

GREAT work mate!!!

@CGijbels

This comment has been minimized.

Show comment
Hide comment
@CGijbels

CGijbels Jul 1, 2013

Collaborator

I changed the css to make sure the links are always underlined and not only on hover

Collaborator

CGijbels commented Jul 1, 2013

I changed the css to make sure the links are always underlined and not only on hover

avanderhoorn added a commit that referenced this pull request Jul 1, 2013

Merge pull request #424 from CGijbels/Issue395
Fix for issue #395 Allowing direct loading of Ajax request from HUD

@avanderhoorn avanderhoorn merged commit 761ea9c into Glimpse:master Jul 1, 2013

1 check passed

default TeamCity Build Glimpse :: Continuous Integration finished: Tests passed: 942, ignored: 10
Details
@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Jul 1, 2013

Member

Great work mate! This will go out with the next release

Member

avanderhoorn commented Jul 1, 2013

Great work mate! This will go out with the next release

@ghost ghost assigned CGijbels Jul 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment