Fix race condition between message bus and subscribers #564

Merged
merged 1 commit into from Oct 25, 2013

Conversation

Projects
None yet
3 participants
@kellystuard
Contributor

kellystuard commented Oct 13, 2013

Now makes list, before returning it, if it doesn't exist. Previously
returned new, empty IEnumerable, each time.
Test was making assumptions about type of IEnumerable being returned.

Fix for #550, including unit tests.
Now makes list, before returning it, if it doesn't exist. Previously
returned new, empty IEnumerable, each time.
Test was making assumptions about *type* of IEnumerable being returned.
@kellystuard

This comment has been minimized.

Show comment
Hide comment
@kellystuard

kellystuard Oct 13, 2013

Contributor

Previous comment, from @CGijbels: "[this] fix is something that we still need to look at, because we've to make sure the change is not going to break other tabs created by the community"

Contributor

kellystuard commented Oct 13, 2013

Previous comment, from @CGijbels: "[this] fix is something that we still need to look at, because we've to make sure the change is not going to break other tabs created by the community"

@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Oct 14, 2013

Member

HUGE thanks on tracking this down. Definitely needs to happen.

@nikmd23 Can you do the code review on this to make sure you are update to date with the change?

Member

avanderhoorn commented Oct 14, 2013

HUGE thanks on tracking this down. Definitely needs to happen.

@nikmd23 Can you do the code review on this to make sure you are update to date with the change?

@nikmd23

This comment has been minimized.

Show comment
Hide comment
@nikmd23

nikmd23 Oct 25, 2013

Member

This looks okay to me!

:shipit:

Member

nikmd23 commented Oct 25, 2013

This looks okay to me!

:shipit:

nikmd23 added a commit that referenced this pull request Oct 25, 2013

@nikmd23 nikmd23 merged commit 9aacb9b into Glimpse:master Oct 25, 2013

@ghost ghost assigned nikmd23 Oct 25, 2013

@kellystuard kellystuard deleted the kellystuard:fix-550-trace-logging branch Feb 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment