Fix for #584 Securing default configuration resource #586

Merged
merged 3 commits into from Oct 22, 2013

Conversation

Projects
None yet
2 participants
@CGijbels
Collaborator

CGijbels commented Oct 22, 2013

No description provided.

CGijbels added some commits Oct 21, 2013

Fix for #584 - Securing Default Resource
- This secures the default resource the same way as normal resources are
secured
- It makes sure as one runtime policy says 'Off' that the others aren't
evaluated anymore
- Makes sure that if Glimpse default runtime policy is configured as
'Off' that the initialization marks the IsInitialized property as true
as well
Re-added CreateAndStartGlobalExecutionTimer...
... to the Initialize method, because although it seems unnecessary, it
actually prevents the alternate dependency resolver to fail when used
during initialization. See commit
1c5a585
@CGijbels

This comment has been minimized.

Show comment
Hide comment
@CGijbels

CGijbels Oct 22, 2013

Collaborator

@nikmd23 Do you remember that commit? Because there is no issue directly linked to it. It also only seems to fail with MVC4 MusicStore sample and not with the MVC3 MusicStore sample. So I have added it again, but maybe something to keep in mind for your instance based framework provider? Since you mentioned that the initialization will not have access to the request store and it seems there is a dependency on it?

@nikmd23 Do you remember that commit? Because there is no issue directly linked to it. It also only seems to fail with MVC4 MusicStore sample and not with the MVC3 MusicStore sample. So I have added it again, but maybe something to keep in mind for your instance based framework provider? Since you mentioned that the initialization will not have access to the request store and it seems there is a dependency on it?

This comment has been minimized.

Show comment
Hide comment
@nikmd23

nikmd23 Oct 22, 2013

Member

Hey @CGijbels, I don't remember that commit specifically - but in hindsight it seems like a hack.

I'll make sure this works properly in the new branch.

Member

nikmd23 replied Oct 22, 2013

Hey @CGijbels, I don't remember that commit specifically - but in hindsight it seems like a hack.

I'll make sure this works properly in the new branch.

@ghost ghost assigned nikmd23 Oct 22, 2013

CGijbels added a commit that referenced this pull request Oct 22, 2013

Merge pull request #586 from Glimpse/no584-securing-default-configura…
…tion-resource

Fix for #584 Securing default configuration resource

@CGijbels CGijbels merged commit e941e1f into master Oct 22, 2013

@ghost ghost assigned CGijbels Oct 22, 2013

@CGijbels CGijbels deleted the no584-securing-default-configuration-resource branch Dec 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment