Disabled Glimpse when request init is bypassed (for #703 #614 #336) #704

Merged
merged 2 commits into from Jan 15, 2014

Conversation

Projects
None yet
2 participants
@CGijbels
Collaborator

CGijbels commented Jan 14, 2014

This is a fix for #703

  • When the HttpRequestStore has not been initialized with a proper RuntimePolicy value because of one of the reasons mentioned in #703, then it will default to RuntimePolicy.Off and that value will be stored and used for that request
  • A message will be logged pointing the #703 so that this behavior won't get unnoticed
@CGijbels

This comment has been minimized.

Show comment
Hide comment
@CGijbels

CGijbels Jan 14, 2014

Collaborator

As a side-note, we need to check whether or not this workaround is also needed for v2 or even whether the new way of working in v2 might even prevent to have this workaround and might fail in those specific cases.

Either way, v2 is not yet there, so this fix might help others in the meanwhile...

Collaborator

CGijbels commented Jan 14, 2014

As a side-note, we need to check whether or not this workaround is also needed for v2 or even whether the new way of working in v2 might even prevent to have this workaround and might fail in those specific cases.

Either way, v2 is not yet there, so this fix might help others in the meanwhile...

nikmd23 added a commit that referenced this pull request Jan 15, 2014

Merge pull request #704 from Glimpse/no703-disable-glimpse-if-request…
…-initialization-is-bypassed

Disabled Glimpse when request init is bypassed

@nikmd23 nikmd23 merged commit 26cf045 into master Jan 15, 2014

@nikmd23 nikmd23 deleted the no703-disable-glimpse-if-request-initialization-is-bypassed branch Jan 15, 2014

@ghost ghost assigned CGijbels Jan 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment