Update Route Inspector to ignore non AspNet based routes (for #365) #723

Merged
merged 8 commits into from Feb 3, 2014

Conversation

Projects
None yet
2 participants
@PaulAtkins
Contributor

PaulAtkins commented Jan 31, 2014

Initial fix for #365 Can no longer access the list of Web API descriptors after installing Glimpse in our MVC4 project.

Todo:

  1. Refactor duplicated code in RouteInspector
  2. Refactor the ProcessWebAPIConstraintsMessage - this was only added due to differences in the RouteDirection between MVC and WebAPI
  3. Legacy projects need updating
  4. Need to add unit tests

PaulAtkins added some commits Jan 30, 2014

Updates for Web API
Added new AlternateType HttpRoute for WebAPI routes
Added new Process Constraint Message type due to differences with MVC
routing
Modified RoutesInspector to work with Web API routing
@PaulAtkins

This comment has been minimized.

Show comment
Hide comment
@PaulAtkins

PaulAtkins Jan 31, 2014

Contributor

@BarryDahlberg This fix is working for me for a MVC5 WebAPI. Can you compile the Glimpse.AspNet project from this branch and add a reference to it to check if it also works with your MVC4 WebAPI, thanks

Contributor

PaulAtkins commented Jan 31, 2014

@BarryDahlberg This fix is working for me for a MVC5 WebAPI. Can you compile the Glimpse.AspNet project from this branch and add a reference to it to check if it also works with your MVC4 WebAPI, thanks

@PaulAtkins

View changes

source/Glimpse.AspNet/Inspector/RoutesInspector.cs
{
- currentRoutes[i] = newObj;

This comment has been minimized.

@PaulAtkins

PaulAtkins Jan 31, 2014

Contributor

System.Web.Http.HttpRouteCollection doesn't have a setter method, do instead use the Remove() and Add() methods.

@PaulAtkins

PaulAtkins Jan 31, 2014

Contributor

System.Web.Http.HttpRouteCollection doesn't have a setter method, do instead use the Remove() and Add() methods.

@PaulAtkins

This comment has been minimized.

Show comment
Hide comment
@PaulAtkins

PaulAtkins Feb 1, 2014

Contributor

I've removed the support for WebApi routes and moved it into a separate branch, so this is now just a one line fix for #365

Contributor

PaulAtkins commented Feb 1, 2014

I've removed the support for WebApi routes and moved it into a separate branch, so this is now just a one line fix for #365

avanderhoorn added a commit that referenced this pull request Feb 3, 2014

Merge pull request #723 from PaulAtkins/master
Can no longer access the list of Web API descriptors after installing Glimpse in our MVC4 project (#365)

@avanderhoorn avanderhoorn merged commit 039e7e0 into Glimpse:master Feb 3, 2014

@avanderhoorn avanderhoorn added Glimpse.MVC and removed Glimpse.MVC labels Feb 3, 2014

@avanderhoorn avanderhoorn added this to the vNext milestone Feb 3, 2014

@avanderhoorn avanderhoorn self-assigned this Feb 3, 2014

avanderhoorn added a commit that referenced this pull request Feb 3, 2014

@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Feb 3, 2014

Member

@PaulAtkins Just wondering if you can sign the CLA and send it through to me as soon as you get a chance - anthony dot vanderhoorn at the place where the google plex has our mail.

Member

avanderhoorn commented Feb 3, 2014

@PaulAtkins Just wondering if you can sign the CLA and send it through to me as soon as you get a chance - anthony dot vanderhoorn at the place where the google plex has our mail.

@PaulAtkins

This comment has been minimized.

Show comment
Hide comment
@PaulAtkins

PaulAtkins Feb 3, 2014

Contributor

@avanderhoorn Yep I can sign the CLA, but it will be a couple of days before I can send it through to you.

Contributor

PaulAtkins commented Feb 3, 2014

@avanderhoorn Yep I can sign the CLA, but it will be a couple of days before I can send it through to you.

@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Feb 3, 2014

Member

Not a problem, just send it through as soon as you can. Thanks again for all your help!

Member

avanderhoorn commented Feb 3, 2014

Not a problem, just send it through as soon as you can. Thanks again for all your help!

PaulAtkins added a commit to PaulAtkins/Glimpse that referenced this pull request Feb 4, 2014

AspNet Route Tab should ignore non AspNet Routes
Linked to #365 and #723, the AspNet Routes Tab should only show AspNet
Routes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment