New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward all parameters in CreateDbCommandDefinition #803

Merged
merged 1 commit into from Jun 12, 2014

Conversation

Projects
None yet
2 participants
@ThomasZitzler

ThomasZitzler commented Jun 4, 2014

Under certain circumstances I get errors out of the wrapped Oracle
provider telling me that some argument is wrong. Forwarding the
providerManifest fixes that issue.

Forward all parameters in CreateDbCommandDefinition
Under certain circumstances I get errors out of the wrapped Oracle
provider telling me that some argument is wrong. Forwarding the
providerManifest fixes that issue.

avanderhoorn added a commit that referenced this pull request Jun 12, 2014

Merge pull request #803 from ThomasZitzler/master
Forward all parameters in CreateDbCommandDefinition

@avanderhoorn avanderhoorn merged commit b7f0535 into Glimpse:master Jun 12, 2014

@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Jun 12, 2014

Member

Wow great fix! Don't know why I wouldn't have done that in the first place. Thanks for the fix.

Member

avanderhoorn commented Jun 12, 2014

Wow great fix! Don't know why I wouldn't have done that in the first place. Thanks for the fix.

@avanderhoorn avanderhoorn self-assigned this Jun 12, 2014

@avanderhoorn avanderhoorn added this to the vNext milestone Jun 12, 2014

@ThomasZitzler

This comment has been minimized.

Show comment
Hide comment
@ThomasZitzler

ThomasZitzler Jun 12, 2014

Thank you for providing such a great piece of software. Looking forward to use it in my project.

ThomasZitzler commented Jun 12, 2014

Thank you for providing such a great piece of software. Looking forward to use it in my project.

@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Jun 12, 2014

Member

Not a problem. Thanks for the fix!

Member

avanderhoorn commented Jun 12, 2014

Not a problem. Thanks for the fix!

@ThomasZitzler

This comment has been minimized.

Show comment
Hide comment
@ThomasZitzler

ThomasZitzler Jun 27, 2014

Could you please also push a new version of Glimpse.EF5 to nuget? Otherwise the fix doesn't work for me...

ThomasZitzler commented Jun 27, 2014

Could you please also push a new version of Glimpse.EF5 to nuget? Otherwise the fix doesn't work for me...

@avanderhoorn avanderhoorn added Glimpse.EF and removed Glimpse.ADO labels Jun 27, 2014

@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Jun 27, 2014

Member

Wow this was missfiled... I should have been put under EF not ADO. My fault.

Member

avanderhoorn commented Jun 27, 2014

Wow this was missfiled... I should have been put under EF not ADO. My fault.

@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Jun 27, 2014

Member

Done! :)

Member

avanderhoorn commented Jun 27, 2014

Done! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment